Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(externals): exclude external child paths from the bundle #186

Merged
merged 1 commit into from
Jun 28, 2020

Conversation

floydspace
Copy link
Contributor

As an example, if aws-sdk is an external, imports from aws-sdk/clients/dynamodb must be excluded from the bundle as well.

Does it make sense @evanw ?

as an example if aws-sdk is external, imports from aws-sdk/clients/dynamodb must be excluded from
bundle as well
Copy link
Owner

@evanw evanw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clean fix, and for adding a test in your PR!

@evanw evanw merged commit 01ed3f8 into evanw:master Jun 28, 2020
@floydspace floydspace deleted the exclude-external-child-paths branch February 20, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants