-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: sub-path module resolve wrong with pkg browser
field
#2001
Conversation
e5f2465
to
ef1f260
Compare
ef1f260
to
e5e149d
Compare
I just tried this out. Your PR does fix that issue. However, it breaks some test cases on https://github.com/evanw/package-json-browser-tests that were previously working, so we'll need to find a different fix that keeps everything working:
The https://github.com/evanw/package-json-browser-tests repo is where I'm have a collection of cross-tool tests for this feature. I'll add your tests from this PR to that repo too. |
Thanks! |
Close #2002