Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #4010: allow define key to start with import. #4013

Closed
wants to merge 1 commit into from
Closed

fix #4010: allow define key to start with import. #4013

wants to merge 1 commit into from
+44 −11

Conversation

sapphi-red
Copy link
Contributor

fixes #4010
fixes #4012

Added import.* handling for ParseGlobalName function to allow import.* to be used in define / pure options.

@sameignatovich sameignatovich mentioned this pull request Dec 20, 2024
Open
7 tasks
sapphi-red
sapphi-red commented Dec 20, 2024
View reviewed changes
internal/js_parser/global_name_parser.go
Comment on lines +27 to +28
result = append(result, lexer.Identifier.String)
lexer.Expect(js_lexer.TIdentifier)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't strictly limit to import.meta here. (import.foo is allowed and import['meta'] is not allowed)

@valentinpalkovic valentinpalkovic mentioned this pull request Dec 20, 2024
Closed
@infomiho infomiho mentioned this pull request Dec 20, 2024
Closed
@k70suK3-k06a7ash1 k70suK3-k06a7ash1 mentioned this pull request Dec 20, 2024
Open
@patak-dev patak-dev mentioned this pull request Dec 20, 2024
Merged
@gbarkhatov gbarkhatov mentioned this pull request Dec 20, 2024
Merged
@evanw evanw closed this in 199a0d3 Dec 20, 2024
@sapphi-red
Copy link
Contributor Author

Thanks for the release!

@sapphi-red sapphi-red deleted the fix/4010-define-import branch December 22, 2024 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artem-oleinychenko artem-oleinychenko artem-oleinychenko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TSUP builds failing after upgrading esbuild to 0.24.1 ERROR: Expected identifier but found "import"
2 participants
@sapphi-red @artem-oleinychenko