Allows NodeJS to terminate also if there is an active service. #656
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #659
Curently, NodeJS will not terminate if there is an esbuild service running.
Running this, will not allow NodeJS to exit.
This pull request allows the possibility to keep the esbuild service running in background ready to receive requests without the need to manually call stop() - NodeJS will terminate automatically when there is no operation in progress (transform, build or serve).
See https://nodejs.org/api/child_process.html#child_process_subprocess_unref for more technical details.
This change should not affect the normal usage, and will allow the implementation of features like experimental module loaders without hanging the NodeJS process and without resorting to restarting the child process every transformation. Will also simplify the usage of this library by bundler and build tools.
More than happy to discuss this.
And thank you again for esbuild!