esbuild-wasm: don't create a new exit0 native module for each run #719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kzc
commented
Jan 28, 2021
kzc
commented
- has a stable file name based on the hash of the contents of the shared library
- saves disk space for repeated runs
evanw
reviewed
Jan 29, 2021
npm/esbuild-wasm/bin/esbuild
Outdated
| const hash = crypto.createHash('sha256').update(data).digest().toString('hex').slice(0, 16); | ||
| const tempFile = path.join(os.tmpdir(), `${hash}-${nativeModule}`); | ||
| try { | ||
| require(tempFile); |
There was a problem hiding this comment.
I think the contents of the file should probably be validated here before using it.
There was a problem hiding this comment.
I had thought about that. It would be yet another read, but sure.
kzc
commented
Jan 29, 2021
npm/esbuild-wasm/bin/esbuild
Outdated
| fs.writeFileSync(tempFile, zlib.inflateRawSync(Buffer.from(data, 'base64'))); | ||
| require(tempFile); | ||
| const data = zlib.inflateRawSync(Buffer.from(base64, 'base64')); | ||
| const hash = crypto.createHash('sha256').update(data).digest().toString('hex').slice(0, 16); |
There was a problem hiding this comment.
It would be faster to hash base64 here rather than data due to its length:
const hash = crypto.createHash('sha256').update(base64).digest().toString('hex').slice(0, 16);What do you think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.