Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Empty log lines on worker error #268

Closed
micon4sure opened this issue Mar 19, 2020 · 1 comment · Fixed by #269
Closed

Empty log lines on worker error #268

micon4sure opened this issue Mar 19, 2020 · 1 comment · Fixed by #269

Comments

@micon4sure
Copy link

Please see TypeStrong/ts-node#945
addaleax added a commit to addaleax/node-source-map-support that referenced this issue Apr 19, 2020
@addaleax
Fix Node.js Worker support by not shimming uncaughtException
3ebcb67 
Node.js Worker threads don’t handle `uncaughtException` the same way
that the main thread does. The shim does not apply/make sense here,
but breaks error handling support in unexpected ways instead.

Fixes: evanw#268
Fixes: TypeStrong/ts-node#945
addaleax added a commit to addaleax/node-source-map-support that referenced this issue Apr 19, 2020
@addaleax
Fix Node.js Worker support by not shimming uncaughtException
1db97ff 
Node.js Worker threads don’t handle `uncaughtException` the same way
that the main thread does. The shim does not apply/make sense here,
but breaks error handling support in unexpected ways instead.

Fixes: evanw#268
Fixes: TypeStrong/ts-node#945
@addaleax addaleax mentioned this issue Apr 19, 2020
Merged
@LinusU
Copy link
Collaborator

LinusU commented Apr 19, 2020

Fixed in version 0.5.17 🚀

bestlucky0825 pushed a commit to bestlucky0825/node-source-map-support that referenced this issue May 30, 2022
@addaleax
Fix Node.js Worker support by not shimming uncaughtException
bdba50e 
Node.js Worker threads don’t handle `uncaughtException` the same way
that the main thread does. The shim does not apply/make sense here,
but breaks error handling support in unexpected ways instead.

Fixes: evanw/node-source-map-support#268
Fixes: TypeStrong/ts-node#945
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Node.js Worker support by not shimming uncaughtException addaleax/node-source-map-support
2 participants
@LinusU @micon4sure