fix: Adapt to node's removal of the module header #255
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of version 11.11.0 (and backported to 10.16), node automatically strips the module closure header from the module source code. So, the fix for that caused off-by-one errors in the sourcemapped file. Set the headerLength to 0 when it is known to not be present.
isaacs
force-pushed
the
node-header-length-change
branch
from
f2f9f1f to
b2e96dd
Compare
Contributor
Author
|
Bonus: updated the test to work with Node 12's new reporting that quotes the invalid token in SyntaxError messages. |
Collaborator
|
Thanks! ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of version 11.11.0 (and backported to 10.16), node automatically strips
the module closure header from the module source code. So, the fix for that
caused off-by-one errors in the sourcemapped file.