-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mimic node more closely #77
Conversation
Test passes in browser! Good to merge 👍 |
Please rebase on master to avoid multiple support charset... commits. |
Done :) |
I find your implementation a bit complicated, why did you not simply change |
You could read some of the reasoning from when I did a similar thing before here: segment-boneyard/oh-crap#1 tl;dr If another module would to the same thing as us, it would break both. |
I am not a fan of redefining |
The only thing that worries me is that we have no guarantee that Node will use |
Hmm, yeah I see your point. Well, I've read the source code and I know that it works for now. I don't see it as such a big risk thought, if that happens we can always fix it then. |
Do not handle `uncaughtException` if there are other listeners
Thanks. |
This is the fix first suggested by @crispy1989 in #46 but tweaked to work better and have correct tests.
It also includes #76 so pull that before pulling this and this pull request should automatically be updated to only show the one relevant commit.
@evanw @julien-f If you want another maintainer I would be willing to help :)