I18n en translations reference #425
Conversation
|
Could you rebase onto main without my commits? Should keep things a little tidier, especially as you're touching a section of the documentation that I haven't. |
|
Just removed them. Somehow the diff to main affects some files I didn't touch. Can investigate again later if necessary. |
carygravel
force-pushed
the
i18n-en-translations-reference
branch
from
aaef6e5 to
54374d3
Compare
|
That's reference finished, I think. Please take a look! |
| allows us to calculate at any point in time the surplus power. Measuring the | ||
| generated power is interesting, but has no effect on the function, with the | ||
| this exception: | ||
| https://docs.evcc.io/docs/guides/meters#ich-habe-eine-pv-anlage-aber-keinen-netzanschluss-z%C3%A4hler-kann-ich-evcc-trotzdem-nutzen |
There was a problem hiding this comment.
Should this be a link to the EN documentation?
|
|
||
| The minimum power required to charge is calculated from the values `minCurrent` | ||
| and `phases`, defined per `loadpoint` (a group of colocated chargers) | ||
| See https://docs.evcc.io/docs/reference/configuration/loadpoints for more |
There was a problem hiding this comment.
Same here (and in other places)
There was a problem hiding this comment.
Yes, this should definitly be a relative link like this:
| See https://docs.evcc.io/docs/reference/configuration/loadpoints for more | |
| See [`loadpoints`](./loadpoints) |
| evcc requires a configuration file in which the system is described. Without | ||
| this file, evcc cannot be used. The file itself is written in | ||
| [YAML](https://en.wikipedia.org/wiki/YAML). This format defines a syntax with | ||
| which data can be structured in plain text. |
There was a problem hiding this comment.
Could this be rephrased to something that flows a little more naturally? I feel like this might be a bit too direct a translation from DE.
|
Looks very nice! Do you have anything beside the linking comments open? Otherwise I would merge this. |
|
@carygravel Any idea what state this is in at the moment? Could just merge this and then tackle the links in a separate issue |
|
@carygravel As suggested by @duckfullstop, I'll merge this now and we can update in smaller increments from there. |
|
Apologies for the lack of response. Things are a little fraught at the moment. I'll fix the comments ASAP. |
This is still a work in progress. Just wanted to be transparent about how far I had got. Note that I started with @duckfullstop 's branch. If his commits are a problem, I can rebase/remove them.