Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modbus proxy: make readonly ignore writes, add deny option (BC) #10658

Merged
merged 5 commits into from
Nov 8, 2023

Conversation

andig
Copy link
Member

@andig andig commented Nov 5, 2023

Valid settings for readonly are:

  • true: writes are ignored (change in behaviour- BC)
  • deny: writes result in errror
  • false: writes are passed through

Cleaner interface depends on go-yaml/yaml#1001

@andig andig requested a review from premultiply November 5, 2023 10:24
@andig andig changed the title Modbus proxy: add readonly ignore mode (BC) Modbus proxy: make readonly ignore writes, add deny option (BC) Nov 5, 2023
@andig andig force-pushed the feature/modbus-proxy-writemode branch from b9c9a0e to 81c7982 Compare November 5, 2023 10:46
@andig andig added the enhancement New feature or request label Nov 5, 2023
@VolkerK62
Copy link
Contributor

Frage, weil BC:
Ich habe readonly in der yaml nicht gesetzt. muss ich etwas ändern?

@andig
Copy link
Member Author

andig commented Nov 5, 2023

Nein, aber falls gesetzt ändert sich das Verhalten von "true".

@andig andig merged commit 0242dad into master Nov 8, 2023
14 checks passed
@andig andig deleted the feature/modbus-proxy-writemode branch November 8, 2023 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants