Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for SMA device config by serial #121

Merged
merged 2 commits into from
May 11, 2020
Merged

Added support for SMA device config by serial #121

merged 2 commits into from
May 11, 2020

Conversation

DerAndereAndi
Copy link
Contributor

  • The SMA Home Manager or Energy Meter device can now be either defined via its IP or its serial number
  • Only URI or serial number needs to be defined in the config file

@DerAndereAndi
Added support for SMA device config by serial
8f05ab9 
- The SMA Home Manager or Energy Meter device can now be either defined via its IP or its serial number
- Only URI or serial number needs to be defined in the config file
andig
andig reviewed May 10, 2020
View reviewed changes
meter/sma.go
}

sma.Instance.Subscribe(uri, sm.recv)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was wenn Beides empty?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ein fatal mit config: prefix hab ich anderswo verwendet.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, sollte man machen. Eines muss definiert sein. Momentan gibt es aber auch keinen Fehler wenn zur Konfiguration nichts gefunden wird

@andig andig added devices Specific device support enhancement New feature or request labels May 11, 2020
@andig andig merged commit 0c18e47 into evcc-io:master May 11, 2020
@DerAndereAndi DerAndereAndi deleted the feature/sma-serial-config branch May 11, 2020 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andig andig andig left review comments

Assignees
No one assigned
Labels
devices Specific device support enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DerAndereAndi @andig