Feature/add hoymiles wifi inverter as a meter #16204
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andig
reviewed
Sep 18, 2024
Co-authored-by: andig <cpuidle@gmail.com>
Co-authored-by: andig <cpuidle@gmail.com>
Co-authored-by: andig <cpuidle@gmail.com>
Co-authored-by: andig <cpuidle@gmail.com>
Co-authored-by: andig <cpuidle@gmail.com>
andig
reviewed
Sep 27, 2024
| // int32 would not be Year 2038 safe | ||
| // See https://en.wikipedia.org/wiki/Year_2038_problem | ||
| // Not 100% sure if the models are self-defined or provided by hoymiles | ||
| request.Time = int32(time.Now().Unix()) |
There was a problem hiding this comment.
Das kann in. Die Initialisierung des Requests mit rein. Eigentlich scheint das aber in die Lib zu gehören?
andig
reviewed
Sep 27, 2024
|
|
||
| result, err := hmWifi.client.GetRealDataNew(request) | ||
| if err != nil { | ||
| if hmWifi.lastValue != 0 && !hmWifi.lastValueUpdated.Add(time.Minute*15).Before(time.Now()) { |
| if hmWifi.lastValue != 0 && !hmWifi.lastValueUpdated.Add(time.Minute*15).Before(time.Now()) { | ||
| hmWifi.lastValue = 0 | ||
| } | ||
| if err.Error() == "client connection is closed" { |
There was a problem hiding this comment.
Offline ist offline- das sollte das Gerät nicht überbrücken.
| sysErr, ok2 := opErr.Err.(*os.SyscallError) | ||
| if ok2 && sysErr.Err == syscall.Errno(10060) { | ||
| hmWifi.log.DEBUG.Printf("HoymilesWifi the Host is offline: %s", hmWifi.cc.Host) | ||
| return hmWifi.lastValue, nil |
| return value, err | ||
| } | ||
|
|
||
| defer func(client *hoymiles_wifi.ClientData) { |
There was a problem hiding this comment.
Das wäre dann
defer client.CloseConnection()
There was a problem hiding this comment.
Aber wozu brauchts das überhaupt?
…r-meter' into feature/add-hoymiles-wifi-inverter-meter
Co-authored-by: andig <cpuidle@gmail.com>
Co-authored-by: andig <cpuidle@gmail.com>
Co-authored-by: andig <cpuidle@gmail.com>
|
I would be really sad if this weren't integrated. |
|
I will prepare a new Commit. I test ist at home. |
|
Let's reopen when updated- thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello Evcc Team,
thx for your good work.
I will now pay some thing bag with this pull request.
It includes the feature:
To my person:
Configuration Inverter:
Library:
Som thing for claification:
Example: