Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update instructions for SolaxCloud #17281

Merged
merged 1 commit into from
Nov 26, 2024
Merged

Update instructions for SolaxCloud #17281

merged 1 commit into from
Nov 26, 2024

Conversation

mrichtarsky
Copy link
Contributor

They appear to have changed. Also, it's important to put the tokenID in quotes, otherwise it gets interpreted as a number.

Issue #17227

They appear to have changed. Also, it's important to
put the tokenID in quotes, otherwise it gets interpreted as
a number.

Issue evcc-io#17227
@andig
Copy link
Member

andig commented Nov 16, 2024

Könnten wir die alte Formulierung belassen und nur den Pfad auf der Webseite aktualisieren?

@andig andig added the devices Specific device support label Nov 16, 2024
@mrichtarsky
Copy link
Contributor Author

Unfortunately, there is no direct URL where the token would be visible, so a descriptions is needed. Also, there is no more "ObtaintokenID". I would also like to point out that the token needs to be quoted. So not much remains of the original text I'm afraid.

@github-actions github-actions bot added the stale Outdated and ready to close label Nov 23, 2024
@mrichtarsky
Copy link
Contributor Author

@andig How can we proceed here? Is there something you want to keep from the old wording/something you don't like about the new wording? Frankly, the old instructions didn't help me with setting up the integration - the URL didn't exist, the token was called something else and when I pasted it I ran into #17227

@github-actions github-actions bot removed the stale Outdated and ready to close label Nov 26, 2024
@andig andig merged commit 5da0a94 into evcc-io:master Nov 26, 2024
@naltatis
Copy link
Member

Kleiner Hinweis: Die Zeichen " und # müssen innerhalb eines Beschreibungstextes in YAML escaped werden.

Hier der Fix: 3940eb3

@oskarfessel
Copy link

Interestingly enough, i get the following error when using this change (in sync with master as of 20241127-11:25 GMT+1):

Starting evcc.
panic: processing template 'meter/solax-hybrid-cloud.yaml' failed: yaml: line 26: mapping values are not allowed in this context

goroutine 1 [running]:
github.com/evcc-io/evcc/util/templates.load(0x2978700?)
github.com/evcc-io/evcc/util/templates/init.go:96 +0x85
github.com/evcc-io/evcc/util/templates.init.0()
github.com/evcc-io/evcc/util/templates/init.go:36 +0xe5

That cannot be right, can it?

Ich kann den Fehler nicht finden...

@oskarfessel
Copy link

Aber @naltatis konnte das offensichtlich. Danke schön.

jonilala796 pushed a commit to jonilala796/evcc that referenced this pull request Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devices Specific device support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants