Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail build when golang version doesn't match #1734

Merged
merged 3 commits into from
Oct 27, 2021

Conversation

DerAndereAndi
Copy link
Contributor

@DerAndereAndi
Copy link
Contributor Author

Das ist ein alternativer Ansatz zu #1733

@andig
Copy link
Member

andig commented Oct 26, 2021

Ich seh's erst jetzt in Ruhe- das ist ja supersmart. Statt neuem Verzeichnis- können wir das einfach in die main.go und server/version.go mit einbauen statt noch nem neuen Ordner? Dann fänd ich das KLASSE!

@andig
Copy link
Member

andig commented Oct 26, 2021

@DerAndereAndi warum nutzen wir nicht einfach das Modul selbst?

@DerAndereAndi
Copy link
Contributor Author

Weil da der Support bei Go1.11 aufgehört hat

@andig andig added the enhancement New feature or request label Oct 26, 2021
@DerAndereAndi
Copy link
Contributor Author

Schaut gut aus, danke für den Kommentar-Fix

@andig andig merged commit d6be967 into master Oct 27, 2021
@andig andig deleted the feature/restrict-build-minimum-go-version branch October 27, 2021 08:01
dontbyte pushed a commit to dontbyte/evcc that referenced this pull request Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants