-
-
Notifications
You must be signed in to change notification settings - Fork 720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tariff: add dynamic/zones charges to ENTSO-e #17417
Conversation
@bartashevich thank you for this PR. Unfortunately, we can't implement it this way: your PR largely duplicates the code that we already have in the fixed tariff. Instead, we need to reuse as much as possible, much more if we want to add this to other tariffs. Also: your example of adding prices for zones is confusing. The price already comes from ENTSO-E, so why would you want to manually define it? |
Fixed zone pricing seems a bit more complex and not easy to adapt for dynamic pricing. In terms of ENTSO-E, price come in raw and we have a lot of custom taxes to apply. And on top of that, we need to apply zoned pricing. I wasn't expecting for this PR to be merged right away. I'm happy to keep on working on this until we reach ideal solution. |
It still seems your example is not using the Entso price add all? |
Also note #17414 which could be used instead of zones? |
ar := api.Rate{ | ||
Start: r.Start, | ||
End: r.End, | ||
Price: t.totalPrice(r.Value), | ||
Price: t.totalPrice(r.Value) + zonePrice, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@andig here zone price is added to ENTSO-e price
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see. Imho that‘s more rigid than necessary.
Can you provide me an example where I can apply both:
|
@andig, What about reusing code from fixed zones by implementing sum of 2 tariffs? If dynamic tariff have zones, it would create fixed tariff entity and then it would sum to current dynamic tariff. Do you think that would work? |
How about, instead of adding zones: charges := 0.0860
if hr := ts.Hour(); hr < 8 || hr >= 23 {
charges = 0.0157
}
(price + 0.004 + 0.0028930 + 0.010) * 1.16 + 0.005 + charges /cc @VolkerK62 @naltatis bzgl. Doku |
dismissed in favor of #17414 |
Fix #12371
Example for BZN|PT domain with feedin and grid:
Same code can be added to other tariffs. Once it reaches final version.