Implementation of PKCE #17683
Merged
Implementation of PKCE #17683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
Oh, should use Go pkce instead of custom, but we can change that later. Much appreciated, thank you! |
andig
reviewed
Dec 10, 2024
| AccessToken string `graphql:"access_token"` | ||
| RefreshToken string `graphql:"refresh_token"` | ||
| ExpiresIn int `graphql:"expires_in"` | ||
| AccessToken string `json:"access_token"` |
There was a problem hiding this comment.
…and this looks like your normal oauth2.Token?
There was a problem hiding this comment.
looks like
{
"scope": "openid profile email customer:attributes",
"client_id": "l3oopkc_10",
"grntid": "pgy8pMOexIftRPxn2d1zpzEtXKAvaTh5",
"iss": "https://polestarid.eu.polestar.com",
"iat": 1733862755,
"jti": "j0WZYyVTPB58DMAsSkImGN",
"market": "DE",
"acr": "urn:polestarid:aal:bronze:any",
"aud": "l3oopkc_10",
"firstName": "Thomas",
"lastName": "Leininger",
"sub": "750d8bdf-cfdd-4b57-8863-545b963598f2",
"mobile": "+49**********",
"pi.sri": "yZ-bFpFvgeXMjGdKSLOmhHUoR58..WKVj.MJUGMYhCMP1AwOj644WNysHjm",
"userName": "rostbeule@gmail.com",
"email": "rostbeule@gmail.com",
"exp": 1733863055
}
But facing 2 warnings:
Looks like your JWT header and signature is not encoded correctly using base64 blablabla...
jonilala796
pushed a commit
to jonilala796/evcc
that referenced
this pull request
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@andig : I changed the auth flow to include PKCE