Improve SMA error handling #1975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Call `UpdateValues()` once. Only on success start the timer with updating the data in a loop. Otherwise return the error
|
Ich würde das logging noch in die UpdateLoop ( |
andig
reviewed
Dec 1, 2021
andig
requested changes
Dec 1, 2021
andig
reviewed
Dec 1, 2021
|
LGTM |
|
Den Fehler löst rebase, hab ich force-pushed, sorry… |
|
@andig ich sehe auf master noch den gleichen commit auf dem ich hier aufgebaut habe, rebase bringt hier nichts. Ging dein Push nicht durch? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Call
UpdateValues()once. Only on success start the timer with updating the data in a loop. Otherwise return the error