Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Template improvements #2019

Merged
merged 26 commits into from
Dec 12, 2021
Merged

Template improvements #2019

merged 26 commits into from
Dec 12, 2021

Conversation

DerAndereAndi
Copy link
Contributor

@DerAndereAndi DerAndereAndi commented Dec 11, 2021 •
edited by andig
Loading

Fix #2018

  • Update go-e firmware requirements
  • Change cfos devices not to use modbus config schema
  • Add support for onIdentify params of vehicles
  • Add support for resetOnDisconnect for loadpoints
  • Add support for defining device specific modbus port, baudrate and comset defaults
  • Handle fatal error when evcc.yaml exists and the process doesn't have write permissions
  • Some bug fixes

@DerAndereAndi DerAndereAndi marked this pull request as draft December 11, 2021 11:34
@DerAndereAndi DerAndereAndi changed the title Update go-e firmware requirements Template improvements Dec 11, 2021
@DerAndereAndi
Copy link
Contributor Author

@andig wenn du magst kannst schon mal drüber schauen

ansonsten was sollte noch dazu? @naltatis @premultiply @andig ?

andig
andig reviewed Dec 12, 2021
View reviewed changes
cmd/configure/survey.go Show resolved Hide resolved
cmd/configure/texts.go Outdated Show resolved Hide resolved
templates/definition/charger/abl.yaml Show resolved Hide resolved
templates/docs/meter/cfos-meter-charge.yaml Outdated Show resolved Hide resolved
util/templates/template_modbus.go Outdated Show resolved Hide resolved
util/templates/template_modbus.go Outdated Show resolved Hide resolved
@DerAndereAndi
Copy link
Contributor Author

@andig die onIdentify parameter sind hiermit flach eingepflegt. Man könnte diese noch anstatt targetSoC als onIdentifyTargetSoC definieren, damit evtl. zukünftige Konflikte nicht auftreten können. Aber denke das ist hier nicht unbedingt notwendig. Oder was meinst du?

@DerAndereAndi DerAndereAndi mentioned this pull request Dec 12, 2021
Closed
@DerAndereAndi DerAndereAndi marked this pull request as ready for review December 12, 2021 15:22
@andig andig added the bug Something isn't working label Dec 12, 2021
@DerAndereAndi DerAndereAndi added the enhancement New feature or request label Dec 12, 2021
@DerAndereAndi DerAndereAndi merged commit 96a0475 into master Dec 12, 2021
@DerAndereAndi DerAndereAndi deleted the feature/update-device-templates branch December 12, 2021 18:56
dontbyte pushed a commit to dontbyte/evcc that referenced this pull request Aug 2, 2022
@DerAndereAndi @dontbyte
Template improvements (evcc-io#2019)
0a99d5b 
Fix evcc-io#2018

- Update go-e firmware requirements
- Change cfos devices not to use modbus config schema
- Add support for `onIdentify` params of vehicles
- Add support for `resetOnDisconnect` for loadpoints
- Add support for defining device specific modbus port, baudrate and comset defaults
- Handle fatal error when `evcc.yaml` exists and the process doesn't have write permissions
- Some bug fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andig andig andig left review comments

Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

onIdentify läuft nicht über type:template
2 participants
@DerAndereAndi @andig