Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ChargeRemainder api #325

Merged
merged 6 commits into from
Sep 13, 2020
Merged

Add ChargeRemainder api #325

merged 6 commits into from
Sep 13, 2020

Conversation

andig
Copy link
Member

@andig andig commented Sep 1, 2020

Fix #298

/cc @premultiply könntest Du schon testen

@andig andig marked this pull request as draft September 1, 2020 07:59
@andig andig changed the title Add ChargeRemainer api Add ChargeRemainder api Sep 1, 2020
@andig andig added the enhancement New feature or request label Sep 1, 2020
@andig andig force-pushed the feature/remaining-time branch from c9233ab to 4002a2f Compare September 1, 2020 15:53
Copy link
Member

@premultiply premultiply left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API v2 muss genutzt werden sonst funktioniert das nicht

vehicle/renault.go Outdated Show resolved Hide resolved
@andig andig force-pushed the feature/remaining-time branch from ecb83b7 to c67656f Compare September 4, 2020 20:21
@andig andig marked this pull request as ready for review September 4, 2020 20:22
@andig
Copy link
Member Author

andig commented Sep 4, 2020

ping @premultiply ready for test

@andig
Copy link
Member Author

andig commented Sep 7, 2020

ping @premultiply hattest Du schon Gelegenheit mal rein zu schauen?

@premultiply
Copy link
Member

Habs installiert konnte aber noch nicht testen. Wird mindestens Mittwoch bei mir.

@andig
Copy link
Member Author

andig commented Sep 11, 2020

ping @premultiply wie siehts hiermit aus?

@premultiply
Copy link
Member

premultiply commented Sep 11, 2020

Funktioniert prinzipiell (wenn eine Ladeprognose von der API kommt).

Problem ist halt wenn keine Prognose von der API kommt das dann nichts angezeigt wird.

@andig
Copy link
Member Author

andig commented Sep 11, 2020

OK. Dann könnten wir noch Fallback auf unser Standardapi einbauen. Letztlich könnte das ja irgendwann mal auf kwh umgestellt oder erweitert werden- ich baue das mal als Alternative ein und dann rein damit.

@andig andig force-pushed the feature/remaining-time branch from 6e486c7 to 57ed9cb Compare September 13, 2020 10:33
@andig
Copy link
Member Author

andig commented Sep 13, 2020

ping @premultiply in Warning umgebaut

@andig andig merged commit 90e23da into master Sep 13, 2020
@delete-merged-branch delete-merged-branch bot deleted the feature/remaining-time branch September 13, 2020 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restladezeit optional von Fahrzeug-API
2 participants