add advanced urlprefix param to volkszaehler-http #3561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sollten wir da bei Volkszähler nicht das |
|
Gibt es soviele https volkszaehler instanzen die ohne auth laufen, dass sich ein breaking change lohnt? |
andig
reviewed
Jun 3, 2022
|
Unter #3665 hat @svendeckert auch ein Problem mit einem volkszahler, welcher nicht im default Pfad läuft |
|
@StefanSchoof wie gehts weiter? Wenn wir das so einloggen gehen bestehende Configs kaputt! Es müsste zumindest noch .host als Fallback abgefragt werden falls das noch gesetzt ist, auch wenn es sich nicht mehr konfigurieren lässt. |
|
So jetzt sollte das nicht mehr breaking sein. |
andig
reviewed
Jun 23, 2022
andig
pushed a commit
that referenced
this pull request
Jun 24, 2022
dontbyte
pushed a commit
to dontbyte/evcc
that referenced
this pull request
Aug 2, 2022
dontbyte
pushed a commit
to dontbyte/evcc
that referenced
this pull request
Aug 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make it possible to differnet url prefixes in volkszaehler
#3556