Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tasmota: simplify and clarify method names #3788

Merged
merged 1 commit into from
Jul 7, 2022
Merged

Tasmota: simplify and clarify method names #3788

merged 1 commit into from
Jul 7, 2022

Conversation

andig
Copy link
Member

@andig andig commented Jul 7, 2022

@thierolm ok for you?

@andig andig added the infrastructure Basic functionality label Jul 7, 2022
@thierolm
Copy link
Contributor

thierolm commented Jul 7, 2022

@andig Fein für mich, wenns vom Meister kommt! ;-)

Schau bitte in dem Kontext auch einmal über meinen Homematic PR #3758.

@andig andig merged commit 48ba7ae into master Jul 7, 2022
@andig andig deleted the fix/tasmota branch July 7, 2022 14:29
@thierolm
Copy link
Contributor

thierolm commented Jul 7, 2022

Hi @andig ich sehe gerade in

SML struct {
TotalIn float64 `json:"total_in"`
TotalOut float64 `json:"total_out"`
PowerCurr int `json:"power_curr"`
}
, dass du die JSON Names klein geschrieben hast. Im Tasmota JSON sind die aber Groß/Klein:

...
"SML": {
			"Total_in": 34505.6822,
			"Total_out": 14736.3054,
			"Power_curr": -511,
			"Meter_number": "****"
},
...

Kann es leider nicht testen.
@dirkclemens könntest du bitte das Grid Meter mit dem aktuellen Commit Stand nochmal testen?
Loop in @VolkerK62

@andig
Copy link
Member Author

andig commented Jul 7, 2022

Das sollte hoffentlich mappen, sonst änder ich das. Grund der Anpassung: die Variablennamen im "go style" halten.

@VolkerK62
Copy link
Contributor

Nightly installiert. Funktioniert ohne Probleme, obwohl ich im Device "Power-curr" hinterlegt habe.

@dirkclemens
Copy link

dirkclemens commented Jul 8, 2022

@thierolm hab gerade das nightly installiert und es klappt auch bei mir weiterhin

tasmota_sml
-----------
[tasmota] TRACE 2022/07/08 07:07:59 GET http://192.168.2.28/cm?cmnd=Status+8&password=&user=
[tasmota] TRACE 2022/07/08 07:07:59 {"StatusSNS":{"Time":"2022-07-08T06:07:59","HTU21":{"Temperature":24.7,"Humidity":39.2},"SML":{"Total_in":34519.3265,"Total_out":14738.3065,"Power_curr":87,"Meter_number":"***"},"Gas":{"Count":1.84},"TempUnit":"C"}}
[tasmota] TRACE 2022/07/08 07:07:59 GET http://192.168.2.28/cm?cmnd=Status+8&password=&user=
[tasmota] TRACE 2022/07/08 07:07:59 {"StatusSNS":{"Time":"2022-07-08T06:07:59","HTU21":{"Temperature":24.7,"Humidity":39.2},"SML":{"Total_in":34519.3265,"Total_out":14738.3065,"Power_curr":87,"Meter_number":"***"},"Gas":{"Count":1.84},"TempUnit":"C"}}
Power:  87W
Energy: 34519.3kWh

@thierolm
Copy link
Contributor

thierolm commented Jul 8, 2022

Top! @VolkerK62 + @dirkclemens Danke fürs Testen!

dontbyte pushed a commit to dontbyte/evcc that referenced this pull request Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Basic functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants