TxProfile rejected #9766
TxProfile rejected #9766
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
premultiply
changed the title
|
Hold your horses. I'm still having reliability issues with this. I am still experimenting. Anyway, the problem with TxDefaultProfile is that it's simply not how this should work. If anybody else sets a TxProfile then that will overrule TxDefaultProfile and evcc can´t regulate anymore. |
|
This is a structural fix. |
|
Gibts hier noch was zu tun? M.E. Bugfix bei ABB? |
|
No, see #8138 . ABB firmware was according to spec after all. I would like to see my car charging properly tomorrow and if successful then I'll click this through to review for you to integrate. I don´t know how to make this a separate PR though, sorry. |
|
Full ack after reading the spec. It seems that our OCPP library does not follow the spec in this regard. |
|
Car still charging today. Looks ok to me. PLease integrate. |
|
Thank you so much for troubleshooting and fixing this! |
|
Hey, this will not work! The duplicate function was there for a reason (or you can solve it with an IF statement if you want). The transactionId can only be passed in setChargingProfile, but not in a RemoteStartTransaction (the transaction is still to be started, so the transactionId is unknown and the spec does not allow it). |
|
Did you try? An unknown txn id is 0 which is the zero value for integers. Due to the omitempty json tag on the field, Go will not include this in the json. |
|
I will give it a try... |
|
Having trouble to test this. I am getting other errors with 0.120.2 , which I can´t really pin down to a specific cause. |
|
Please start discussion with logfile. Be aware of #10029. Lets close here- this has already been confirmed working. |
|
This is working for me. |
For #8138 discussion. Do not commit.