Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/loadpoint sync charger #9932

Merged
merged 3 commits into from
Sep 17, 2023
Merged

Fix/loadpoint sync charger #9932

merged 3 commits into from
Sep 17, 2023

Conversation

GrimmiMeloni
Copy link
Collaborator

fix #9928

@GrimmiMeloni
Copy link
Collaborator Author

successfully tested locally, in combination with #9866

@andig
Copy link
Member

andig commented Sep 17, 2023

Das ist unglücklich weil wir damit wieder zurück gehen an die Stelle wo syncCharger selber hart Änderungen durchführt. Genau das wollten wir ja nicht mehr?

@GrimmiMeloni
Copy link
Collaborator Author

Wir wollten einen unerwarteten Ladevorgang nicht mehr hart abschalten nur um dann im Regelintervall direkt wieder einzuschalten.
Dieser Change verändert das auch nicht. Es wird lediglich einem bereits aktiv ladenden Charger gesagt er möge sich aktivieren. Das dient einzig dazu den State intern gerade zu ziehen und sollte keinen Effekt auf den laufenden Ladevorgang haben.

@andig
Copy link
Member

andig commented Sep 17, 2023

Da hast du natürlich auch wieder recht :)

@andig andig merged commit a2865f7 into evcc-io:master Sep 17, 2023
@andig andig added the bug Something isn't working label Sep 17, 2023
@MarkusGH MarkusGH mentioned this pull request Sep 18, 2023
Closed
naltatis pushed a commit that referenced this pull request Sep 19, 2023
@GrimmiMeloni @naltatis
Fix loadpoint not setting charging charger to enabled (#9932)
8b06c7e
@GrimmiMeloni GrimmiMeloni mentioned this pull request Sep 22, 2023
Merged
@GrimmiMeloni GrimmiMeloni deleted the fix/loadpointSyncCharger branch October 20, 2023 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Loadpoint stuck with "Charger Logic error" after restart
2 participants
@GrimmiMeloni @andig