Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use php7.4 functionality #5

Merged
merged 1 commit into from
Feb 18, 2020
Merged

Conversation

arnedesmedt
Copy link
Contributor

Hi,

I've used the new type hinting functionality for properties in PHP 7.4 to create more efficient ImmutableRecords.

But the only problem is that it would give conflicts if people still use older PHP versions. Maybe you can create a dev branch for the PHP 7.4 functionality or merge this branch in master and create a dev branch for people who want to use older PHP versions?

What are your taughts about the last problem?

@codeliner
Copy link
Contributor

really nice. Thank you @arnedesmedt
I'd do the following:
It's time to tag a v1.0 version. The package is pretty stable and used a lot in different important projects (important for my company and our clients). The current master becomes v1.0.
After that, I'll merge your PR and create a v2.0-beta.1 for those who are on PHP7.4 and want to make use of prop types within ImmutableRecords. When v2.0-beta.x feels stable and projects switch to it, I'd turn it into v2.0.

@codeliner codeliner merged commit acd56a8 into event-engine:master Feb 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants