Added functionality to retrieve ids of all docs that match a given filter #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…havior regarding sequential arrays
codeliner
reviewed
Mar 20, 2020
| * @param array $array2 | ||
| * @return array | ||
| */ | ||
| private function arrayReplaceRecursiveAssocOnly(array $array1, array $array2): array |
There was a problem hiding this comment.
@jsor @heiglandreas can you take a look at these changes as well? It only affects testing environment and should not cause any existing tests to fail, but at least you should know about the change ;)
codeliner
approved these changes
Mar 24, 2020
heiglandreas
approved these changes
Mar 24, 2020
|
|
||
| private function isSequentialArray(array $array): bool | ||
| { | ||
| if (\count($array) === 0) { |
There was a problem hiding this comment.
I would write that as if ($array === []) { as that's one function call less ;-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.