Skip to content

Commit

Permalink
chore(build): Fix build in Node 10 by updating yarn.lock (#32)
Browse files Browse the repository at this point in the history
[Build was breaking](https://travis-ci.org/eventbrite/eventbrite-sdk-javascript/builds/374217527) on `'node'` version in Travis because `'node'` now points to new v10 that that was released. One of gulp's dependencies didn't work correctly with it. See: gulpjs/gulp#2162 (comment).

The fix was to `yarn remove gulp gulp-debug` and `yarn add --dev gulp gulp-debug`. This bumped `gulp-debug` to a new version, but the main fix was the updates to `yarn.lock` to use new versions of packages specifically `natives@1.1.13`.
  • Loading branch information
benmvp authored and BenAtEventbrite committed May 3, 2018
1 parent 7539725 commit 363634b
Show file tree
Hide file tree
Showing 2 changed files with 100 additions and 71 deletions.
7 changes: 5 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@
"eslint-plugin-typescript": "^0.9.0",
"gulp": "^3.9.1",
"gulp-babel": "^7.0.1",
"gulp-debug": "^3.2.0",
"gulp-debug": "^4.0.0",
"gulp-rename": "^1.2.2",
"gulp-replace": "^0.6.1",
"gulp-sourcemaps": "^2.6.4",
Expand Down Expand Up @@ -106,6 +106,9 @@
}
],
"jest": {
"projects": ["jest-test.config.js", "jest-lint.config.js"]
"projects": [
"jest-test.config.js",
"jest-lint.config.js"
]
}
}
Loading

0 comments on commit 363634b

Please sign in to comment.