Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SPCO Copy Attendee Data Closes #3102 #3116

Merged
merged 2 commits into from
Sep 4, 2020
Merged

Fix SPCO Copy Attendee Data Closes #3102 #3116

merged 2 commits into from
Sep 4, 2020

Conversation

tn3rb
Copy link
Member

@tn3rb tn3rb commented Sep 4, 2020

see #3102

This PR fixes the attendee data copy functionality on the single page checkout (SPCO) by:

  • making sure that jQuery assets are always registered for all "asset" requests (HTTP web requests)

  • localizes ee i18n strings for the espresso_core script

  • auto formats the CoreAssetManager

@tn3rb tn3rb self-assigned this Sep 4, 2020
manzoorwanijk
manzoorwanijk approved these changes Sep 4, 2020
View reviewed changes
Copy link
Contributor

@manzoorwanijk manzoorwanijk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

@tn3rb tn3rb merged commit 4258a9b into barista-prod Sep 4, 2020
@tn3rb tn3rb deleted the copy-attendee-data branch September 4, 2020 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manzoorwanijk manzoorwanijk manzoorwanijk approved these changes

Assignees

@tn3rb tn3rb

Labels
category:spco-&-registration status:review type:bug 🐞
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tn3rb @manzoorwanijk