Allow multiple categories to be used in ESPRESSO_EVENTS #3125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he categories passed.
…m each element in the array to remove whitespaces Use $event_category_slugs_array to build out an placeholder string to be used with prepare. (Count the number of slugs and add N number of placeholders to a string) Switch to use IN in the SQL query and pass both $event_category_slugs_prepare and $event_category_slugs_array to prepare.
tn3rb
reviewed
Sep 17, 2020
| return sanitize_title_with_dashes(EE_Registry::instance()->REQ->get('event_query_category', $category)); | ||
| return sanitize_text_field(EE_Registry::instance()->REQ->get('event_query_category', $category)); |
tn3rb
approved these changes
Sep 17, 2020
Pebblo
assigned sethshoultes, lorenzocaum, garthkoyle and kristinoc and unassigned tn3rb
|
This works as expected. Nice work! |
eeteamcodebase
pushed a commit
that referenced
this pull request
Sep 17, 2020
…tiple categories to be used in ESPRESSO_EVENTS (#3125) * Switch to sanitize_text_field() so that dashes aren't stripped from the categories passed. * Build out $event_category_slugs_array from whatever is passed and trim each element in the array to remove whitespaces Use $event_category_slugs_array to build out an placeholder string to be used with prepare. (Count the number of slugs and add N number of placeholders to a string) Switch to use IN in the SQL query and pass both $event_category_slugs_prepare and $event_category_slugs_array to prepare. * Add braces around $event_category_slugs_prepare * Style fixes."
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: https://eventespresso.com/topic/multiple-categories-in-shortcode-filter/
From the above request I start looking into do it via a support token, ended up finding:
https://events.codebasehq.com/projects/event-espresso/tickets/7323
How has this been tested
Add something like
[ESPRESSO_EVENTS category_slug=cat-1]to a page.Confirm that events set to that category show up and not others.
Change is to
[ESPRESSO_EVENTS category_slug='cat-1'](Note the single quotes, because people do it)..Then change that to
[ESPRESSO_EVENTS category_slug=cat-1,cat-2](Note no quotes required as there isn't a space in the shortcode)
Now check that event from both cat-1 and cat-2 show up.
Then change that to
[ESPRESSO_EVENTS category_slug='cat-1, cat-2'](single quotes required as there's a space this time)
Again confirm that the expected events show up.
Checklist
esc_html__(), see https://codex.wordpress.org/I18n_for_WordPress_Developers)