Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

$this->datetimes_for_event should not be filled with array #4101

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

Arjen-Smit
Copy link

Problem this Pull Request solves

When filtering registrations on an event an error is thrown cause the $datetimes_for_event is filled with an array instead of a DatetimesForEventCheckIn.

How has this been tested

Steps to reproduce error:

  • Go to Admin -> Event Espresso -> Registrations.
  • Select Event Check-in
  • Select an Event in the Filters and press Filter.

Checklist

$datetimes_for_event should be filled with a DatetimesForEventCheckIn but the method datetimes_ordered() returns an array.
@tn3rb
Copy link
Member

tn3rb commented Dec 12, 2022

thanks @Arjen-Smit

this has already been fixed in the upcoming verion of EE

@Arjen-Smit
Copy link
Author

Hi @tn3rb
This got me a bit confused, I would think dev is the upcoming version of EE?

Is there any indication when this will be available ?
We are currently using the dev version because we needed the recurring events feature for our platform.

@tn3rb
Copy link
Member

tn3rb commented Dec 15, 2022

This got me a bit confused, I would think dev is the upcoming version of EE?

HA! Yes that would make sense wouldn't it?

Because of the difficulties developing new features and/or refactoring code when changes span across multiple plugins, we decided to merge all of our 50-60 active repos into a single monorepo. So now all PHP development for all of our active plugins happens on a single private repo.

I'm currently wrestling with getting all of the CI/CD stuff configured for automagically deploying code to our various servers, services, and public repos like this one, but that's a crazy jigsaw puzzle to work with.
Since that's not ready yet, I can try to get dev branch here updated manually within the next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants