Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: bump busboy version to v1 #2

Merged
merged 2 commits into from
Jun 20, 2022
Merged

feat: bump busboy version to v1 #2

merged 2 commits into from
Jun 20, 2022

Conversation

fatwong
Copy link

@fatwong fatwong commented Jun 20, 2022 •
edited
Loading

Bumped busboy version to 1.6.0 and revised source codes based on below changes from mscdex/busboy#266:

  • No more constructor
  • Use 'close' event instead of 'finish' event when you need to execute
  • something whether the busboy stream encountered an error or not
  • Some 'field' and 'file' event handler parameters have changed
    • Truncated flags, encoding, and mime type information have been consolidated into a single object passed to the event handlers

chkjohn
chkjohn approved these changes Jun 20, 2022
View reviewed changes
Copy link

@chkjohn chkjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Didn't test

@fatwong fatwong merged commit dedba8e into master Jun 20, 2022
@fatwong
Copy link
Author

fatwong commented Jun 20, 2022

M: Upgrade packages with vulnerabilities to resume yarn audit in CI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chkjohn chkjohn chkjohn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fatwong @chkjohn