Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/errors #65

Merged
merged 3 commits into from
Dec 25, 2023
Merged

Fix/errors #65

merged 3 commits into from
Dec 25, 2023

Conversation

NdekoCode
Copy link
Contributor

@NdekoCode NdekoCode commented Dec 25, 2023 •
edited
Loading

  • make filters working
  • remove completely line "Filters / Reset"
  • Correction of cropped images on the left side
  • Make "ever-co" to be clickable and link to https://github.com/ever-co
  • Make "helm-charts" to be clickable and link to https://github.com/ever-co/ever-charts
  • Make screenshot to be clickable and route to the same page as click on "Details" button
  • Make logo at footer / header to be clickable and lead to https://ever.co
  • Links "Terms of Service", "Privacy Policy" and "Cookie Policy"
  • Make sure that the number of stars for each "project" is dynamic.
  • Call "Ever Gauzy API", not "Ever Gauzy Api"
  • add to the "source" field for each chart link to the "source" code of relevant project.

@evereq evereq marked this pull request as ready for review December 25, 2023 17:01
@evereq evereq merged commit 17cfe6f into develop Dec 25, 2023
4 checks passed
@evereq evereq deleted the fix/errors branch December 25, 2023 17:02
@evereq
Copy link
Member

evereq commented Dec 25, 2023

@NdekoCode keep fixing remaining issues, for now merged what you already had in branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evereq evereq Awaiting requested review from evereq

@Saif-Uz-Zaman Saif-Uz-Zaman Awaiting requested review from Saif-Uz-Zaman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NdekoCode @evereq