Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Impl/order history expo #1506

Closed

Conversation

Sergemuhundu
Copy link

@Sergemuhundu Sergemuhundu commented Jul 24, 2022

**Please note: we will close your PR without comment if you do not check the box

How it looks now

WhatsApp Image 2022-07-23 at 05 24 15 (1)
es above and provide ALL requested information.**


Lenscorpx and others added 5 commits July 16, 2022 13:42
…1481)

* Initialization ever flutter shop mobile

* Update AuthService.ts

* Reverted License file and readme file updated and also moved all file to root folder

* Added localization for flutter shop mobile order

* Restructured the project, fixing duplicates

* Restructured the project, updated README FILE

* Imported language pack from existing ionic and added french package for the Ever Demand Flutter version

* Adding the navbar

* Adjusted login design

* Updated design

* Fixed translation bug in arb files

* Fixed arb files

* Updated login screen

* Added ever logo and ever motto

* Added a thank your for signing layout

* updated signup files

* updated and added layouts

* Changed the logo display on phone

* Added circular progress

* Adding products and navigation drawer

* moved menu.dart to menu folder

* feat: project architecture

* feat: screens ui

* Update README.md

Co-authored-by: Ruslan Konviser <evereq@gmail.com>
Co-authored-by: Aaron-Laxis Dizele <aldizele@gmail.com>
@Sergemuhundu Sergemuhundu requested a review from Neosoulink July 24, 2022 18:01
@CLAassistant
Copy link

CLAassistant commented Jul 24, 2022

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
0 out of 2 committers have signed the CLA.

❌ Sergemuhundu
❌ Lenscorpx
You have signed the CLA already but the status is still pending? Let us recheck it.

@evereq
Copy link
Member

evereq commented Jul 24, 2022

@Sergemuhundu , please click the button "CLA | not signed yet" (#1506 (comment)) and follow the requirements of it to sign the CAA document.

@Neosoulink Neosoulink added the type: enhancement ✨ New feature or request label Jul 26, 2022
@Neosoulink
Copy link
Contributor

Neosoulink commented Jul 26, 2022

@Sergemuhundu, I have some propositions regarding the codes:

When importing dependencies or components, can you follow some classification rules for them?

i.e:

// COMPONENTS
import MyCOmponent from "./components/MyComponent";

// STYLES
import STYLES from "./styles";

It's easier to find your way around and to have a clean code;

@Neosoulink Neosoulink requested a review from evereq July 26, 2022 11:09
@Neosoulink
Copy link
Contributor

❗❗ @Sergemuhundu,
I don't think we can merge these codes, you took the codes from another branch intended for the implementation of the Flutter clone

@Neosoulink
Copy link
Contributor

❗❗ @Sergemuhundu, I don't think we can merge these codes, you took the codes from another branch intended for the implementation of the Flutter clone

You have to create a branch from this feature branch

@Neosoulink
Copy link
Contributor

Neosoulink commented Jul 26, 2022

There are too many changes that you didn't implement that end up in this PR;

Try to create another branch from feature/shop-mobile-expoV0.4.3 and name it impl/shop-mobile-expoV0.4.3@orderHistory.

I close this PR

@Neosoulink Neosoulink closed this Jul 26, 2022
@Sergemuhundu Sergemuhundu deleted the Impl/OrderHistoryExpo branch July 26, 2022 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement ✨ New feature or request
Development

Successfully merging this pull request may close these issues.

5 participants