Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Common Toggle Switcher #8468

Merged
merged 2 commits into from
Oct 21, 2024
Merged

Conversation

rahul-rocket
Copy link
Collaborator

@rahul-rocket rahul-rocket commented Oct 21, 2024

PR

Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.


Summary by CodeRabbit

  • New Features

    • Introduced ToggleSwitcherComponent to replace the previous toggle switch functionality, enhancing user interaction.
    • Added JobSearchStoreService for managing job search availability status, providing better control for users.
  • Bug Fixes

    • Updated event bindings for the toggle switch to improve functionality and ensure consistent behavior.
  • Documentation

    • Updated export statements to reflect the new component names and services, ensuring clarity in usage.
  • Chores

    • Removed deprecated components and related files to streamline the codebase.

Copy link
Contributor

coderabbitai bot commented Oct 21, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request introduces several modifications primarily focused on renaming and restructuring components related to toggle functionality across various parts of the application. The <ngx-toggle-switch> component has been renamed to <ngx-toggle-switcher>, and corresponding event bindings have been updated. Additionally, new services and components have been added, while some existing components related to the toggle functionality have been removed. The overall structure and logic of the application remain intact, ensuring consistent user interface elements and functionality.

Changes

File Change Summary
apps/gauzy/src/app/pages/integrations/components/integration-list/list.component.html Renamed <ngx-toggle-switch> to <ngx-toggle-switcher> and updated event binding from (switched) to (onSwitched).
packages/plugins/integration-github-ui/src/lib/components/view/view.component.ts Renamed ToggleSwitchComponent to ToggleSwitcherComponent and updated event binding to onSwitched.
packages/plugins/job-employee-ui/src/lib/components/job-employee/job-employee.component.ts Added JobSearchStoreService, replaced SmartTableToggleComponent with ToggleSwitcherComponent, and removed updateJobSearchAvailability method.
packages/ui-core/core/src/lib/services/job/index.ts Removed export for job.service and added export for job-search.store.service.
packages/ui-core/core/src/lib/services/job/job-preset.service.ts Consolidated import statements for API_PREFIX and toParams.
packages/ui-core/core/src/lib/services/job/job-search.store.service.ts Introduced JobSearchStoreService class with updateJobSearchAvailability method.
packages/ui-core/shared/src/lib/smart-data-layout/index.ts Removed export for smart-table-toggle.component.
packages/ui-core/shared/src/lib/smart-data-layout/smart-data-view-layout.module.ts Removed CommonModule import and SmartTableToggleComponent from COMPONENTS array.
packages/ui-core/shared/src/lib/smart-data-layout/smart-table-toggle/smart-table-toggle.component.html Deleted file containing HTML for SmartTableToggleComponent.
packages/ui-core/shared/src/lib/smart-data-layout/smart-table-toggle/smart-table-toggle.component.spec.ts Deleted unit tests for SmartTableToggleComponent.
packages/ui-core/shared/src/lib/smart-data-layout/smart-table-toggle/smart-table-toggle.component.ts Deleted SmartTableToggleComponent class.
packages/ui-core/shared/src/lib/table-components/index.ts Replaced export for toggle-switch component with toggle-switcher component.
packages/ui-core/shared/src/lib/table-components/table-components.module.ts Renamed ToggleSwitchComponent to ToggleSwitcherComponent in module declarations.
packages/ui-core/shared/src/lib/table-components/toggle-switch/toggle-switch.component.html Deleted file containing HTML for toggle-switch.component.
packages/ui-core/shared/src/lib/table-components/toggle-switcher/toggle-switcher.component.html Added new HTML template for ToggleSwitcherComponent.
packages/ui-core/shared/src/lib/table-components/toggle-switcher/toggle-switcher.component.ts Renamed class and selector from ToggleSwitchComponent to ToggleSwitcherComponent, updated properties and methods accordingly.

Possibly related PRs

🐇 In the garden where toggles play,
The switches dance both night and day.
With names anew, they leap and bound,
In every click, a joy is found!
So let us cheer for changes bright,
As toggles shine with pure delight! 🌼


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@rahul-rocket rahul-rocket merged commit 0db3a2c into develop Oct 21, 2024
11 of 19 checks passed
@rahul-rocket rahul-rocket deleted the fix/toggle-switcher-component branch October 21, 2024 07:03
Copy link

nx-cloud bot commented Oct 21, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit fc98cdf. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


🟥 Failed Commands
nx build gauzy -c=production --prod --verbose
nx build desktop --prod --base-href ./
✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant