Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add issueType && taskStatus fields #8531

Merged
merged 2 commits into from
Nov 8, 2024
Merged

Conversation

samuelmbabhazi
Copy link
Contributor

@samuelmbabhazi samuelmbabhazi commented Nov 8, 2024

PR

Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.


Summary by CodeRabbit

  • New Features

    • Introduced an optional issueType property to categorize tasks in the task interface.
    • Enhanced time log reports to include additional fields such as taskStatus and issueType, enriching the data returned.
  • Bug Fixes

    • Improved data integrity in time log retrieval methods by including relevant task information.

Copy link
Contributor

coderabbitai bot commented Nov 8, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request introduces a new optional property issueType to the ITask interface, facilitating task categorization. Additionally, methods in the TimeLogService class, specifically getTimeLogs, getDailyReport, and getWeeklyReport, are updated to include new fields such as taskStatus and issueType in their returned data structures. The overall functionality and control flows of these methods remain unchanged.

Changes

File Path Change Summary
packages/contracts/src/task.model.ts Added optional property issueType?: string; to ITask interface.
packages/core/src/time-tracking/time-log/... Updated method signatures for getTimeLogs, getDailyReport, and getWeeklyReport to include taskStatus and issueType in the returned data.

Possibly related PRs

Poem

🐰 In the garden of tasks, new fields take flight,
With issueType added, our vision is bright.
Time logs now richer, with statuses clear,
Each task's little story, we hold dear.
Hopping through code, with joy we embrace,
Enhancements like flowers, in this coding space! 🌼


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@samuelmbabhazi samuelmbabhazi marked this pull request as ready for review November 8, 2024 09:50
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 5309b21 and d9b09f7.

📒 Files selected for processing (2)
  • packages/contracts/src/task.model.ts (1 hunks)
  • packages/core/src/time-tracking/time-log/time-log.service.ts (4 hunks)
🔇 Additional comments (5)
packages/contracts/src/task.model.ts (1)

44-44: Verify naming consistency between 'issueType' and 'types'.

The interface uses issueType for a single value but types (using TaskTypeEnum) for filtering in IGetTasksByViewFilters. This naming inconsistency could lead to confusion.

packages/core/src/time-tracking/time-log/time-log.service.ts (4)

96-109: LGTM: Well-structured task status fields addition

The addition of comprehensive task status fields and issueType enhances the task information returned by the getTimeLogs method. The structure follows TypeORM best practices.


128-128: LGTM: Proper relation addition for task status

The addition of 'task.taskStatus' relation ensures that the newly added task status fields are properly loaded.


362-375: LGTM: Consistent task status field implementation

The addition of task status fields in getDailyReport maintains consistency with the getTimeLogs implementation, following the same well-structured pattern.


405-407: LGTM: Proper task status relation in daily report

The addition of the task status relation in getDailyReport ensures proper data loading and maintains consistency with the overall implementation.

packages/contracts/src/task.model.ts Show resolved Hide resolved
Copy link

nx-cloud bot commented Nov 8, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit d9b09f7. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


🟥 Failed Commands
nx build gauzy -c=production --prod --verbose

Sent with 💌 from NxCloud.

@rahul-rocket rahul-rocket merged commit faf89ba into develop Nov 8, 2024
10 of 17 checks passed
@rahul-rocket rahul-rocket deleted the fix/add-all-task-data branch November 8, 2024 11:46
@coderabbitai coderabbitai bot mentioned this pull request Jan 6, 2025
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants