-
Notifications
You must be signed in to change notification settings - Fork 574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add issueType && taskStatus fields #8531
Conversation
Caution Review failedThe pull request is closed. WalkthroughThe pull request introduces a new optional property Changes
Possibly related PRs
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (2)
packages/contracts/src/task.model.ts
(1 hunks)packages/core/src/time-tracking/time-log/time-log.service.ts
(4 hunks)
🔇 Additional comments (5)
packages/contracts/src/task.model.ts (1)
44-44
: Verify naming consistency between 'issueType' and 'types'.
The interface uses issueType
for a single value but types
(using TaskTypeEnum
) for filtering in IGetTasksByViewFilters
. This naming inconsistency could lead to confusion.
packages/core/src/time-tracking/time-log/time-log.service.ts (4)
96-109
: LGTM: Well-structured task status fields addition
The addition of comprehensive task status fields and issueType enhances the task information returned by the getTimeLogs method. The structure follows TypeORM best practices.
128-128
: LGTM: Proper relation addition for task status
The addition of 'task.taskStatus' relation ensures that the newly added task status fields are properly loaded.
362-375
: LGTM: Consistent task status field implementation
The addition of task status fields in getDailyReport maintains consistency with the getTimeLogs implementation, following the same well-structured pattern.
405-407
: LGTM: Proper task status relation in daily report
The addition of the task status relation in getDailyReport ensures proper data loading and maintains consistency with the overall implementation.
☁️ Nx Cloud ReportCI is running/has finished running commands for commit d9b09f7. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution
Sent with 💌 from NxCloud. |
PR
Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.
Summary by CodeRabbit
New Features
issueType
property to categorize tasks in the task interface.taskStatus
andissueType
, enriching the data returned.Bug Fixes