-
Notifications
You must be signed in to change notification settings - Fork 574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix]: Improve find projects by employee #8548
Conversation
WalkthroughThe changes introduce an optional Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (2)
packages/contracts/src/organization-projects.model.ts
(1 hunks)packages/core/src/organization-project/organization-project.service.ts
(2 hunks)
🔇 Additional comments (1)
packages/core/src/organization-project/organization-project.service.ts (1)
316-316
: Verify the default value assignment for relations
The addition of relations = []
in the destructuring of input
defaults the relations
property to an empty array if it is undefined. Ensure that this default aligns with the intended behavior and that the IOrganizationProjectsFindInput
interface marks relations
as optional.
PR
Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.
Summary by CodeRabbit
New Features
relations
property for enhanced querying of organization projects.findByEmployee
method to allow for more flexible query options with the newrelations
parameter.Improvements
pagination
method to improve tag filtering and case-insensitive name matching.