Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Issue on adding new package #1631

Closed
YehualashetGit opened this issue Oct 24, 2023 · 4 comments
Closed

[Bug] Issue on adding new package #1631

YehualashetGit opened this issue Oct 24, 2023 · 4 comments
Assignees
Labels
bug Something isn't working dependencies Pull requests that update a dependency file WEB Web app
Milestone

Comments

@YehualashetGit
Copy link
Contributor

YehualashetGit commented Oct 24, 2023

Currently, we are encountering an issue when attempting to add a new package into our apps. This issue results in the following example error message:

here is the command under the corresponding apps directory

yarn add packageName

i.e

 cd app/web
 yarn add @tanstack/react-table

image

@YehualashetGit YehualashetGit added WEB Web app dependencies Pull requests that update a dependency file labels Oct 24, 2023
@evereq
Copy link
Member

evereq commented Oct 24, 2023

@YehualashetGit what command do you run!?

@evereq evereq added the bug Something isn't working label Oct 24, 2023
@evereq evereq added this to the v0.1.0 milestone Oct 24, 2023
@evereq evereq changed the title issue on adding new pacakge [Bug] Issue on adding new package Oct 24, 2023
@YehualashetGit
Copy link
Contributor Author

@YehualashetGit what command do you run!?

I have updated the issue with the command I run

@evereq
Copy link
Member

evereq commented Oct 24, 2023

@maceteligolden did you run yarn policies set-version 1.19.0 and result of PR #1633 is what happens after you run that command?

I found yarnpkg/yarn#8405 and in one of comments they suggest to update nx / lerna packages to latest, did you checked that? yarnpkg/yarn#8405 (comment)

I don't like idea to pin Yarn version that way, however seems others doing it too, e.g. https://github.com/vuetifyjs/vuetify/tree/master/.yarn/releases. Still if we can resolve this without adding yarn binary to our repo that would be preferred approach.

Also, maybe we just need to try yarn v2? :))) No idea if it will work well with all deps we have / with NX and with Lerna etc...

@maceteligolden
Copy link
Contributor

maceteligolden commented Oct 24, 2023

@maceteligolden did you run yarn policies set-version 1.19.0 and result of PR #1633 is what happens after you run that command?

I found yarnpkg/yarn#8405 and in one of comments they suggest to update nx / lerna packages to latest, did you checked that? yarnpkg/yarn#8405 (comment)

I don't like idea to pin Yarn version that way, however seems others doing it too, e.g. https://github.com/vuetifyjs/vuetify/tree/master/.yarn/releases. Still if we can resolve this without adding yarn binary to our repo that would be preferred approach.

Also, maybe we just need to try yarn v2? :))) No idea if it will work well with all deps we have / with NX and with Lerna etc...

yes @evereq i updated the yarn policies. i'll check updating nx and lerna.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies Pull requests that update a dependency file WEB Web app
Projects
Status: Done
Development

No branches or pull requests

3 participants