Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/add package issue #1633

Merged
merged 2 commits into from
Oct 24, 2023
Merged

Fix/add package issue #1633

merged 2 commits into from
Oct 24, 2023

Conversation

maceteligolden
Copy link
Contributor

No description provided.

@CLAassistant
Copy link

CLAassistant commented Oct 24, 2023

CLA assistant check
All committers have signed the CLA.

@socket-security
Copy link

New dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
@tanstack/react-table 8.10.7 None +2 7.35 MB tannerlinsley

@YehualashetGit
Copy link
Contributor

@maceteligolden At the moment, our current workaround for installing a new package involves manually adding the package to the package.json file and then running yarn install. We would like to learn about your recommended solution along with the corresponding command to execute

@maceteligolden
Copy link
Contributor Author

@YehualashetGit in this PR i have been able to enable installation using
yarn add package-name
My solution involved setting a yarn policy for the application

@YehualashetGit
Copy link
Contributor

@YehualashetGit in this PR i have been able to enable installation using yarn add package-name My solution involved setting a yarn policy for the application

Great, I can help with testing by checking out to your branch.

@maceteligolden
Copy link
Contributor Author

@YehualashetGit alright, please let me know how it goes

@evereq
Copy link
Member

evereq commented Oct 24, 2023

@maceteligolden please accept CAA agreement by clicking button in the comment #1633 (comment)

@YehualashetGit
Copy link
Contributor

@YehualashetGit alright, please let me know how it goes

@maceteligolden yes I've tested, and now we can install new package without any issue

@evereq
Copy link
Member

evereq commented Oct 24, 2023

OK, @maceteligolden did you checked if update to NX / Lerna can solve this issue without need to add Yarn policy?

@maceteligolden
Copy link
Contributor Author

@evereq i was able to upgrade nx and lerna to the latest versions. it didn't resolve the issue

@evereq
Copy link
Member

evereq commented Oct 24, 2023

@maceteligolden ok, thanks! I think we will merge this PR for now and see how it goes

@evereq evereq merged commit b54401b into develop Oct 24, 2023
@evereq evereq deleted the fix/add-package-issue branch October 24, 2023 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants