(apps/web)[fix]: Task Labels UI on Task Component

[Cedric921]

Description

Fix Task Labels Dropdown Size

Type of Change

• Bug fix
• New feature
• Breaking change
• Documentation update

Checklist

• My code follows the style guidelines of this project
• I have performed a self-review of my code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings

Previous screenshots

Current screenshots

Summary by CodeRabbit

• New Features
  • Enhanced dropdown components for task statuses, improving usability and visual layout.
• Style
  • Updated styling for TaskLabels and TaskStatus components for better visual consistency.
  • Increased height of TaskLabels for improved presentation.
• Bug Fixes
  • Streamlined logic for item selection and removal in dropdowns, enhancing functionality.

[coderabbitai]

Walkthrough

The pull request includes modifications to three components: AuthUserTaskInput, TaskInput, and TaskStatus. Changes primarily focus on updating the styling and layout of the TaskLabels component in both AuthUserTaskInput and TaskInput, including adjustments to padding and z-index values. The TaskStatus component sees enhancements in dropdown functionality and styling, ensuring better usability and visual consistency. Overall, these changes are centered around improving the user interface without altering the core functionality.

Changes

File Path	Change Summary
apps/web/lib/features/auth-user-task-input.tsx	Updated taskStatusClassName prop of TaskLabels to simplify padding while retaining background and border styles.
apps/web/lib/features/task/task-input.tsx	Increased z-index and height of TaskLabels, modifying its class name for improved layout.
apps/web/lib/features/task/task-status.tsx	Enhanced MultipleStatusDropdown rendering logic, adjusted z-index and styling, and streamlined item selection logic.

Possibly related PRs

• fix: task input dropdowns #3152: Modifies the AuthUserTaskInput component, directly related to the TaskLabels component.
• show notifications acordingly to selected team #3181: Involves task-related components, potentially overlapping with the main PR's concerns.
• [Feat]:create TimesheetCard component with customizable props #3191: Introduces a TimesheetCard component, suggesting a relationship in UI consistency with TaskLabels.
• [Fix]: Timesheet-UI #3203: Modifications to FrequencySelect, possibly relating to the task management UI.
• Feat: Implement Timesheet Filter Component With Status, Date Filters #3208: Introduces a Timesheet Filter Component, which may interact with TaskLabels.
• [Feat]: Implement dynamic date range picker for timesheet filtering #3213: Implements a dynamic date range picker for timesheet filtering, potentially relating to task representation.
• [Feat]: Create RejectSelectedModal Component #3233: Introduction of RejectSelectedModal, may overlap with TaskLabels functionality.
• [Feat]:Implement EditTaskModal component with enhanced task editing UI  #3238: Focuses on task editing, directly related to the task management features in the main PR.
• we should not plan the same task twice #3244: Addresses duplicate task planning, closely related to the overall task management functionality.

Suggested labels

WEB

Suggested reviewers

• evereq

🐰 In the meadow where tasks do bloom,
A sprinkle of style to brighten the room.
With dropdowns that dance and labels that shine,
Our interface sparkles, oh how divine!
A hop and a skip, we make it all right,
Celebrating changes, our future is bright! 🌼✨

Warning

There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure.

🔧 eslint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

apps/web/lib/features/auth-user-task-input.tsx

Oops! Something went wrong! :(

ESLint: 8.46.0

ESLint couldn't find the config "next/core-web-vitals" to extend from. Please check that the name of the config is correct.

The config "next/core-web-vitals" was referenced from the config file in "/apps/web/.eslintrc.json".

If you still have problems, please stop by https://eslint.org/chat/help to chat with the team.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

🧹 Outside diff range and nitpick comments (1)

apps/web/lib/features/task/task-status.tsx (1)

1246-1246: Consider using design system z-index tokens instead of arbitrary values.

Using arbitrary z-index values like z-[999] can lead to maintainability issues. Consider defining and using standardized z-index tokens from your design system.

-'absolute right-0 left-0 z-[999] min-w-min outline-none',
+'absolute right-0 left-0 z-dropdown min-w-min outline-none',

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 1a1d0c6 and 9eff73f.

📒 Files selected for processing (3)

• apps/web/lib/features/auth-user-task-input.tsx (1 hunks)
• apps/web/lib/features/task/task-input.tsx (1 hunks)
• apps/web/lib/features/task/task-status.tsx (1 hunks)

✅ Files skipped from review due to trivial changes (1)

• apps/web/lib/features/task/task-input.tsx

🔇 Additional comments (2)

apps/web/lib/features/auth-user-task-input.tsx (2)

55-55: Verify the dark theme styling implementation

The removal of explicit padding (py-[7px]) in favor of dark theme styling could affect the component's vertical alignment with adjacent dropdowns. Please ensure this change maintains visual consistency with other dropdowns that still use py-1.5.

Consider extracting these dark theme styles into a shared class or theme configuration to maintain consistency across similar components.

---

Line range hint 58-69: Address commented-out mobile view implementation

The mobile view implementation is currently commented out. This could impact the responsive design of the task input interface on smaller screens.

Run the following script to check for mobile view implementations across the codebase:

Either:

1. Remove the commented code if it's no longer needed
2. Implement a proper mobile view if responsive design is required
3. Add a TODO comment explaining why this is temporarily disabled