Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix [User Team Card] size and user team cart activity #3328

Conversation

NdekoCode
Copy link
Contributor

@NdekoCode NdekoCode commented Nov 12, 2024

Fix User Team Card size and user team cart activity

With a view to solving this bug #3279, I thought it would be preferable to have the activities and tasks layout placed in a column.
In this way, we might be able to retrieve data from other activities in the future:

  • ACTIVITIES
    • Worked Time
    • Avg. Activity
    • Focus Time
    • Work time classification
  • TASKS | SCREENSHOTS | APPS | VISITED SITES

So the layout could look like this:

  • Activities (Avg. Activity, Worked Time, Focus Time, Work time classification)
  • Tasks (Sort by current sort)

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Previous screenshots

Please add here videos or images of previous status

Screen.Recording.2024-11-12.at.16.03.19.mov

Current screenshots

Please add here videos or images of previous status

Uploading Screen Recording 2024-11-12 at 15.52.58.mov…

Summary by CodeRabbit

  • New Features

    • Improved layout and styling for the "Activity for Today" component.
  • Style

    • Adjusted CSS class orders for better consistency.
    • Changed layout from horizontal to vertical flexbox for enhanced organization.
    • Added responsive width constraints to the shadowed box for better adaptability.

Copy link
Contributor

coderabbitai bot commented Nov 12, 2024

Walkthrough

The pull request introduces several modifications to the UserTeamActivity component in user-team-card-activity.tsx. Key changes include a reordering of CSS class attributes, a transition from a horizontal to a vertical flexbox layout, adjustments to the alignment and spacing of inner elements, and the addition of responsive width constraints for the shadowed box. These modifications primarily focus on enhancing the layout and styling of the component without impacting its core functionality.

Changes

File Path Change Summary
apps/web/lib/features/team/user-team-card/user-team-card-activity.tsx - Reordered class attributes for the title element.
- Changed layout from horizontal flexbox to vertical flexbox.
- Updated inner div class for alignment and spacing.
- Modified shadowed box class to include responsive width constraints.
- Adjusted class attributes for Tab.Panel components.

Suggested labels

WEB

Suggested reviewers

  • evereq
  • Cedric921

Poem

🐇 In the meadow where the bunnies play,
A new layout blooms bright as the day.
With boxes that flex and titles that shine,
Our user team card is looking divine!
Hops of joy for the changes made,
In the world of code, let’s dance and parade! 🎉

Warning

There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure.

🔧 eslint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

apps/web/lib/features/team/user-team-card/user-team-card-activity.tsx

Oops! Something went wrong! :(

ESLint: 8.46.0

ESLint couldn't find the config "next/core-web-vitals" to extend from. Please check that the name of the config is correct.

The config "next/core-web-vitals" was referenced from the config file in "/apps/web/.eslintrc.json".

If you still have problems, please stop by https://eslint.org/chat/help to chat with the team.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@NdekoCode NdekoCode self-assigned this Nov 12, 2024
@NdekoCode NdekoCode added this to the v0.2.0 milestone Nov 12, 2024
@NdekoCode NdekoCode marked this pull request as ready for review November 12, 2024 14:12
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Outside diff range and nitpick comments (1)
apps/web/lib/features/team/user-team-card/user-team-card-activity.tsx (1)

36-44: Consider simplifying the responsive constraints

The current implementation uses multiple width constraints that might be redundant:

  • basis-1/4 isn't necessary when you're already using min-w-56 max-w-80
  • The wrap class on the parent suggests multiple cards, but only one is rendered

Consider simplifying to:

-<div className="flex items-center gap-3 wrap">
-  <div className="shadow basis-1/4 min-w-56 max-w-80 rounded-md w-full p-4 m-4 h-32 bg-light--theme-light dark:bg-[#26272C]">
+<div className="flex items-center">
+  <div className="shadow min-w-[14rem] max-w-[20rem] rounded-md w-full p-4 m-4 h-32 bg-light--theme-light dark:bg-[#26272C]">
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 1a1d0c6 and 32da600.

📒 Files selected for processing (1)
  • apps/web/lib/features/team/user-team-card/user-team-card-activity.tsx (2 hunks)
🔇 Additional comments (1)
apps/web/lib/features/team/user-team-card/user-team-card-activity.tsx (1)

34-36: LGTM: Layout changes align with requirements

The transition to a column layout with proper spacing improves the visual hierarchy and matches the PR objectives for better activity organization.

@evereq evereq merged commit a8b08d6 into develop Nov 14, 2024
13 checks passed
@evereq evereq deleted the fix/3279-user-team-card-component-size-in-en-larged-mode-on-the-dashboard branch November 14, 2024 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Fixed the size of the ‘UserTeamCard’ component in Enlarged Mode on the Dashboard home page.
2 participants