-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix [User Team Card] size and user team cart activity #3328
Fix [User Team Card] size and user team cart activity #3328
Conversation
WalkthroughThe pull request introduces several modifications to the Changes
Suggested labels
Suggested reviewers
Poem
Warning There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure. 🔧 eslint
apps/web/lib/features/team/user-team-card/user-team-card-activity.tsxOops! Something went wrong! :( ESLint: 8.46.0 ESLint couldn't find the config "next/core-web-vitals" to extend from. Please check that the name of the config is correct. The config "next/core-web-vitals" was referenced from the config file in "/apps/web/.eslintrc.json". If you still have problems, please stop by https://eslint.org/chat/help to chat with the team. Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Outside diff range and nitpick comments (1)
apps/web/lib/features/team/user-team-card/user-team-card-activity.tsx (1)
36-44
: Consider simplifying the responsive constraintsThe current implementation uses multiple width constraints that might be redundant:
basis-1/4
isn't necessary when you're already usingmin-w-56 max-w-80
- The
wrap
class on the parent suggests multiple cards, but only one is renderedConsider simplifying to:
-<div className="flex items-center gap-3 wrap"> - <div className="shadow basis-1/4 min-w-56 max-w-80 rounded-md w-full p-4 m-4 h-32 bg-light--theme-light dark:bg-[#26272C]"> +<div className="flex items-center"> + <div className="shadow min-w-[14rem] max-w-[20rem] rounded-md w-full p-4 m-4 h-32 bg-light--theme-light dark:bg-[#26272C]">
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
apps/web/lib/features/team/user-team-card/user-team-card-activity.tsx
(2 hunks)
🔇 Additional comments (1)
apps/web/lib/features/team/user-team-card/user-team-card-activity.tsx (1)
34-36
: LGTM: Layout changes align with requirements
The transition to a column layout with proper spacing improves the visual hierarchy and matches the PR objectives for better activity organization.
Fix
User Team Card
size and user team cart activityWith a view to solving this bug #3279, I thought it would be preferable to have the
activities
andtasks
layout placed in a column.In this way, we might be able to retrieve data from other activities in the future:
TASKS
|SCREENSHOTS
|APPS
|VISITED SITES
So the layout could look like this:
Type of Change
Checklist
Previous screenshots
Please add here videos or images of previous status
Screen.Recording.2024-11-12.at.16.03.19.mov
Current screenshots
Please add here videos or images of previous status
Uploading Screen Recording 2024-11-12 at 15.52.58.mov…
Summary by CodeRabbit
New Features
Style