Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EVG-19627 Upgrade gqlgen and otelgqlgen #6564

Merged
merged 4 commits into from
May 31, 2023
Merged

EVG-19627 Upgrade gqlgen and otelgqlgen #6564

merged 4 commits into from
May 31, 2023

Conversation

khelif96
Copy link
Contributor

@khelif96 khelif96 commented May 30, 2023 •
edited
Loading

EVG-19627

Description

Upgrades gqlgen and otelgqlgen to the latest releases

Migrates to Apollo Studio instead of GraphIQL which has a bunch of advantages including:

  • An improved query builder to make debugging and testing queries easy.
  • Multiple tabs and request history to see previously executed graphql queries.
  • Auto Generated GraphQL API documentation as long as we leave comments in our source code.
image

The generated files changed to add some metadata about gqlgen as well as the below changes
99designs/gqlgen#2436

Testing

Tested make gqlgen and also did a spot check to make sure traces still go to the honeycomb

@khelif96 khelif96 marked this pull request as ready for review May 30, 2023 20:00
@khelif96 khelif96 requested review from a team May 30, 2023 20:00
ybrill
ybrill approved these changes May 30, 2023
View reviewed changes
Copy link
Contributor

@ybrill ybrill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm from a plt perspective

@khelif96 khelif96 merged commit 74b6716 into evergreen-ci:main May 31, 2023
@khelif96 khelif96 deleted the EVG-19627 branch May 31, 2023 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@minnakt minnakt minnakt approved these changes

@ybrill ybrill ybrill approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@khelif96 @ybrill @minnakt