-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DEVPROD-335: upgrade PyYaml to 6.0+ to fix cython_sources issue #44
Conversation
pyproject.toml
Outdated
@@ -21,7 +21,7 @@ click = "^8" | |||
plumbum = "^1.7.0" | |||
Inject = "^4.3.1" | |||
structlog = "^21.1.0" | |||
PyYAML = "^5.4.1" | |||
PyYAML = "6.0.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason that we pin this specific version (not a range)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1. I think this should be PyYAML = "^6.0.1"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
@@ -33,6 +33,7 @@ pytest = "^7.0" | |||
black = "^22.3" | |||
pytest-black = "^0.3" | |||
pytest-cov = "^2.8" | |||
importlib_metadata = "^4.13" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did you add this as a dependency?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The flake8 tests were failing https://parsley.mongodb.com/test/evg_module_manager_macos_1014_unit_tests_3.7_patch_832639cf64eb0c4d086506089a24f8f4ba839a2a_65416ad5d6d80a87a8ae8320_23_10_31_21_00_06/0/7b09f16a3440bb7e229b21e73629877f?bookmarks=0,25&shareLine=1
This error happens as flake8 depends on a older version of importlib_metadata
python/importlib_metadata#406
The way to avoid this error was to either comment the tests out or downgrade the library.
Ticket
DEVPROD-335
What
Following error appeared while setting up remote workstation
This came from
evg-module-manager
which still points toPyYAML 5.4.1
. This version has known issue with new cython version. Previous issues with similar fixesUpgraded the PyYaml to 6.0.1 to fix this issue
Tests done
poetry install
poetry run pytest
(ended with mypy error)