This repository has been archived by the owner on Jul 2, 2024. It is now read-only.
DEVPROD-4976: Use temporary AWS credentials from ec2.assume_role command #493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing run #5106 ↗︎
Details:
Review all test suite changes for PR #493 ↗︎ |
||||||||||||||||||||
julianedwards
approved these changes
Feb 21, 2024
| @@ -341,14 +355,16 @@ functions: | |||
| params: | |||
| working_dir: parsley | |||
| shell: bash | |||
| env: | |||
There was a problem hiding this comment.
Non-blocking suggestion: would it be better to use subprocess.exec instead of shell.exec throughout this config?
There was a problem hiding this comment.
for sure! I fixed one of the easy ones, but the other ones make me a bit nervous so I'll open a ticket to audit this usage!
SupaJoon
approved these changes
Feb 21, 2024
minnakt
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEVPROD-4976
Description
Use
ec2.assume_roleand its associated credentials in.evergreen.yml.Testing