This repository has been archived by the owner on Jul 2, 2024. It is now read-only.
DEVPROD-5529 Update logkeeper bootstrap script with additional environment variables #514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing run #5418 ↗︎
Details:
Review all test suite changes for PR #514 ↗︎ |
||||||||||||||||||||
minnakt
approved these changes
Mar 18, 2024
| @@ -49,4 +49,4 @@ fi | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
i notice a random unused variable called SPRUCE_DIR in here 👀 could maybe delete
scripts/bootstrap-logkeeper.sh
Outdated
| @@ -49,4 +49,4 @@ fi | |||
|
|
|||
|
|
|||
| echo "Use the following command to start logkeeper:" | |||
There was a problem hiding this comment.
it could be helpful to mention that the command should be run from your logkeeper directory (wherever it exists)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEVPROD-5529
Description
This should hopefully make starting logkeeper for the first time easier.