This repository was archived by the owner on Jul 2, 2024. It is now read-only.
DEVPROD-787: Retry Node installation on CI #2281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minnakt
changed the title
2 flaky tests on run #16014 ↗︎
Details:
|
|||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| host section > using legacy ssh > shows an error when selecting an incompatible host communication method |
Screenshots
Video
|
|
version/downstream_projects.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| Downstream Projects Tab > shows the child patches |
Screenshots
Video
|
|
Review all test suite changes for PR #2281 ↗︎
khelif96
reviewed
Mar 1, 2024
| # Retry the download for Node in case it flakes. | ||
| for i in {1..5}; do | ||
| nvm install --no-progress --default ${node_version} | ||
| [[ $? -eq 0 ]] && break |
There was a problem hiding this comment.
nit. Can we add some logging here so we know its retrying?
There was a problem hiding this comment.
here is a patch with the message
khelif96
approved these changes
Mar 1, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEVPROD-787
Description
The Node installation can sometimes fail due to network errors. This PR retries the installation 5 times, with a 10 second waiting period between each try. I can raise the waiting time if you guys think it should be higher!
Will open Parsley PR after I get approval.
Testing
"Running in the loop."printed. The timestamps of these messages are kinda weird but I assume that's a symptom of how the agent processes output because the task takes as long as I would expect.