DEVPROD-13581 bump @leafygreen-ui/tabs from 11.2.0 to 13.1.1 and refactor tab logic #521

dependabot · 2024-11-25T18:29:39Z

Bumps @leafygreen-ui/tabs from 11.2.0 to 13.1.1.

Release notes

Sourced from @leafygreen-ui/tabs's releases.

@leafygreen-ui/tabs@13.1.1

Patch Changes

bca3969cf: Removes incorrect setSelectedd prop. setSelected is the correct prop.

@leafygreen-ui/tabs@13.1.0

Minor Changes
30f111498: LG-4473 Updates the selected and setSelected props to accept both strings and numbers. The string must match the text content from the name prop on the Tab component.
  const [selectedTab, setSelectedTab] = useState<string | number>('Tab 4');
return (
<div>
<Button onClick={() => setSelectedTab('Tab 2')}>
Set second tab as active
</Button>
<Tabs
selected={selectedTab}
setSelected={setSelectedTab}
>
<Tab name="Tab 1">
Content 1
</Tab>
<Tab name="Tab 2">
Content 2
</Tab>
<Tab name="Tab 3">
Content 3
</Tab>
<Tab name="Tab 4">
Content 4
</Tab>
<Tabs>
</div>
);
Patch Changes

Updated dependencies [9776f5f42]

@leafygreen-ui/hooks@8.2.0

@leafygreen-ui/tabs@13.0.1

Patch Changes

e7bc12814: Adds more thorough test coverage for disabled inputs

Updated dependencies [c1b8b633b]

Updated dependencies [fe2483937]

... (truncated)

Commits

e77667e Version Packages (#2556)
2033292 Version Packages (#2554)
ba51267 LG-4620: ChartCard and Header components (#2550)
5626b54 LG-4682: Update icon build script path (#2552)
89ada4b Version Packages (#2553)
22d5b2d Lg 4664: Add revert icon (#2551)
bca3969 LG-4680: Tabs removes setSelectedd prop (#2548)
172df2d Version Packages (#2544)
65c6f32 LG-4507: bump packages to @leafygreen-ui/form-field v1.2.5 (#2543)
eb914eb Version Packages (#2542)
Additional commits viewable in compare view

You can trigger a rebase of this PR by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

@dependabot rebase will rebase this PR
@dependabot recreate will recreate this PR, overwriting any edits that have been made to it
@dependabot merge will merge this PR after your CI passes on it
@dependabot squash and merge will squash and merge this PR after your CI passes on it
@dependabot cancel merge will cancel a previously requested merge and block automerging
@dependabot reopen will reopen this PR if it is closed
@dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
@dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
@dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

Bumps [@leafygreen-ui/tabs](https://github.com/mongodb/leafygreen-ui) from 11.2.0 to 13.1.1. - [Release notes](https://github.com/mongodb/leafygreen-ui/releases) - [Commits](https://github.com/mongodb/leafygreen-ui/compare/@leafygreen-ui/tabs@11.2.0...@leafygreen-ui/tabs@13.1.1) --- updated-dependencies: - dependency-name: "@leafygreen-ui/tabs" dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>

This reverts commit 7fe5575.

khelif96 · 2024-12-02T17:25:15Z

This is delayed on https://jira.mongodb.org/browse/LG-4696 I'll get to it once they release a fix

…3.1.1

minnakt · 2024-12-19T21:22:27Z

apps/spruce/src/pages/configurePatch/configurePatchCore/useConfigurePatch/index.ts

+    if (!urlTab || !tabToIndexMap[urlTab]) {
+      setSelectedTab(ConfigurePatchPageTabs.Tasks);
+    }
+  }, []);


nit. fix eslint warning either by adding comment or dependencies

minnakt · 2024-12-19T21:23:32Z

apps/spruce/src/pages/configurePatch/configurePatchCore/useConfigurePatch/index.ts

  useTabShortcut({
-    currentTab: selectedTab,
+    currentTab: tabToIndexMap[state.selectedTab],
    numTabs: indexToTabMap.length,
-    setSelectedTab,
+    setSelectedTab: (i: number) => setSelectedTab(indexToTabMap[i]),
  });

+  // Handle redirecting to the correct tab if the tab is not active
+  useEffect(() => {
+    if (!urlTab || !tabToIndexMap[urlTab]) {
+      setSelectedTab(ConfigurePatchPageTabs.Tasks);


could we group these hooks all together just for organizational purposes? (i.e. put the hooks first, then put the set functions after)

minnakt · 2024-12-19T21:25:40Z

apps/spruce/src/pages/configurePatch/index.tsx

-  if (!validateObjectId(patchId)) {
-    // @ts-expect-error: FIXME. This comment was added by an automated script.
-    return <Navigate to={getVersionRoute(patchId)} />;
+  if (!validateObjectId(patchId || "")) {


can we extract this function call and use it both here and on L26 i.e.

const isMainlineVersion = !validateObjectId(patchId || "")

minnakt · 2024-12-19T21:28:59Z

apps/spruce/src/pages/version/Tabs/index.tsx

+    if (sendAnalytics) {
+      sendEvent({ name: "Changed tab", tab: newTab });


does this ever get called? It seems like whenever we're calling the handleTabChange function in this file, sendAnalytics is false

Thanks fixed!

minnakt · 2024-12-19T21:32:59Z

apps/spruce/src/components/styles/StyledTabs.tsx

  }
-`;
+` as ComponentType<TabsProps>;


is the as ComponentType<TabsProps> necessary?

I think we may also want to respond on LG-4696. I think the typing of setSelected seems to be funky, not sure why they prescribe using Dispatch<SetStateAction<number>> and not a more flexible implementation

Yes it is to get it to work well with Emotion. I left a comment on the slack thread irt the weird Dispatch<SetState... typing but I also followed up on the ticket

…tch hook

minnakt · 2024-12-20T15:43:05Z

apps/spruce/src/pages/version/Tabs/index.tsx

-      navigate(getVersionRoute(versionId), { replace: true });
+  const handleTabChange = (
+    newTab: VersionPageTabs,
+    sendAnalytics: boolean = false,


I think it makes sense to make it a required parameter since the argument is always being provided

Suggested change

sendAnalytics: boolean = false,

sendAnalytics: boolean,

…3.1.1

dependabot bot requested a review from a team as a code owner November 25, 2024 18:29

dependabot bot added the dependencies Pull requests that update a dependency file label Nov 25, 2024

dependabot bot requested a review from khelif96 November 25, 2024 18:29

dependabot bot mentioned this pull request Nov 25, 2024

CHORE(NPM) - bump @leafygreen-ui/tabs from 11.2.0 to 13.1.0 #496

Closed

khelif96 added 6 commits November 27, 2024 13:01

Remove ts-expect-error

280f945

Split out types for patchtab and versiontabs

c2fbd85

Remove unused legacy status

7fe5575

Revert "Remove unused legacy status"

ab93392

This reverts commit 7fe5575.

Update tests to use new enums

741833e

Remove ts-expect-errors

3dcdd14

khelif96 removed the request for review from a team December 2, 2024 17:25

khelif96 added 16 commits December 6, 2024 11:39

Fix typing

f1155f0

Ts-expect-error

c13ed40

Merge branch 'main' into dependabot/npm_and_yarn/leafygreen-ui/tabs-1…

b00ba6e

…3.1.1

Fix styling

3c564e5

Bump snapshots

ab5a7d6

Fix slug usage on configure patch routes

7e28fa6

Remove unused util methods

e73ff8d

Fix logic in configurePatch hook

9227cbe

Begin adding selectedTabName field

cf751dc

Begin extracting state logic to seperate file

2619c2e

Refactor tab logic to use named tab params

445d7f7

Fix ts errors

64d7d17

Remove unused params

0d7fcb0

Merge branch 'main' into dependabot/npm_and_yarn/leafygreen-ui/tabs-1…

dd8a85c

…3.1.1

Bump snapshots

073c6db

Move tabs over to nested folder

e12b0e2

khelif96 changed the title ~~CHORE(NPM) - bump @leafygreen-ui/tabs from 11.2.0 to 13.1.1~~ DEVPROD-13581 bump @leafygreen-ui/tabs from 11.2.0 to 13.1.1 and refactor tab logic Dec 17, 2024

khelif96 added 2 commits December 18, 2024 13:56

Fix eslint error in tabs

4633136

Skip configure query if it won't return anything

54b6ecb

khelif96 requested a review from minnakt December 18, 2024 19:06

khelif96 added 5 commits December 18, 2024 17:32

snapshots

d56fce4

Rename tasks folder to Tasks

99cf169

snapshots

56d5cb0

Bump snapshots

4ad1749

Bump types

c103e0c

minnakt reviewed Dec 19, 2024

View reviewed changes

khelif96 added 5 commits December 19, 2024 17:50

Refactor patch ID validation for improved readability

415dfb0

Add ESLint disable comment for exhaustive-deps rule in useConfigurePa…

a01405f

…tch hook

consolidate useEffects

8d4cb4e

Update handleTabChange to include a second argument

444b3e8

snapshots

1343c30

minnakt approved these changes Dec 20, 2024

View reviewed changes

khelif96 added 8 commits December 23, 2024 12:10

Move useQueryVariables closer to usage

865ebc5

fix import

55673fe

Rely on versionId prop

7f8043b

Ensure selected tab is defined

087668f

Remove default param

438a40b

Merge branch 'main' into dependabot/npm_and_yarn/leafygreen-ui/tabs-1…

41e5cc9

…3.1.1

Ensure tab is updated when its changed

a59ee2b

Preserve query params when navigating

b5eb04f

khelif96 enabled auto-merge (squash) December 26, 2024 21:33

khelif96 added 4 commits December 26, 2024 17:08

Bump snapshots

3907a1f

snapshots

64ab444

Disable inconsistent storyshots

221bfd1

please work this time

cc85600

khelif96 merged commit a6634f6 into main Dec 27, 2024
6 checks passed

khelif96 deleted the dependabot/npm_and_yarn/leafygreen-ui/tabs-13.1.1 branch December 27, 2024 19:14

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

DEVPROD-13581 bump @leafygreen-ui/tabs from 11.2.0 to 13.1.1 and refactor tab logic #521

DEVPROD-13581 bump @leafygreen-ui/tabs from 11.2.0 to 13.1.1 and refactor tab logic #521

dependabot bot commented on behalf of github Nov 25, 2024 •

edited

Loading

khelif96 commented Dec 2, 2024

minnakt Dec 19, 2024

minnakt Dec 19, 2024

minnakt Dec 19, 2024

minnakt Dec 19, 2024

khelif96 Dec 19, 2024

minnakt Dec 19, 2024

khelif96 Dec 19, 2024

minnakt Dec 20, 2024

		if (sendAnalytics) {
		sendEvent({ name: "Changed tab", tab: newTab });

DEVPROD-13581 bump @leafygreen-ui/tabs from 11.2.0 to 13.1.1 and refactor tab logic #521

DEVPROD-13581 bump @leafygreen-ui/tabs from 11.2.0 to 13.1.1 and refactor tab logic #521

Conversation

dependabot bot commented on behalf of github Nov 25, 2024 • edited Loading

@​leafygreen-ui/tabs@​13.1.1

Patch Changes

@​leafygreen-ui/tabs@​13.1.0

Minor Changes

Patch Changes

@​leafygreen-ui/tabs@​13.0.1

Patch Changes

khelif96 commented Dec 2, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dependabot bot commented on behalf of github Nov 25, 2024 •

edited

Loading

`@leafygreen-ui/tabs@13`.1.1

`@leafygreen-ui/tabs@13`.1.0

`@leafygreen-ui/tabs@13`.0.1