Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEVPROD-12285: Allow users to modify volume size #656

Merged
merged 6 commits into from
Feb 27, 2025

Conversation

minnakt
Copy link
Contributor

@minnakt minnakt commented Feb 26, 2025

DEVPROD-12285

Description

Shows size as a field in the EditVolumeModal.

Volume size can only be increased, not decreased. This is simply a rule that comes from AWS

Screenshots

Screenshot 2025-02-25 at 8 09 23 PM

Testing

  • Add Cypress tests

@minnakt minnakt added the spruce label Feb 26, 2025
@minnakt minnakt marked this pull request as ready for review February 26, 2025 14:38
@minnakt minnakt requested a review from a team as a code owner February 26, 2025 14:38
Copy link
Contributor

@SupaJoon SupaJoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Saving the volume doesn't persist and I'm unsure if this is a limitation of the testing environment.

bug.mov

@minnakt
Copy link
Contributor Author

minnakt commented Feb 26, 2025

Saving the volume doesn't persist and I'm unsure if this is a limitation of the testing environment.

bug.mov

since the changes are deployed on production, you can test against production and check that the volume size changes (at least it looks like its updating for me)

@minnakt minnakt requested a review from SupaJoon February 26, 2025 18:32
@minnakt
Copy link
Contributor Author

minnakt commented Feb 26, 2025

I also just learned you can only edit volume size once every 6 hours; I'll add a disclaimer about that in the modal

@minnakt minnakt merged commit 7944801 into evergreen-ci:main Feb 27, 2025
3 checks passed
@minnakt minnakt deleted the DEVPROD-12285 branch February 27, 2025 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants