Skip to content

Conversation

asafdav
Copy link
Contributor

@asafdav asafdav commented Jul 27, 2012

Generally I've made some required changes in order to use this package for google prediction api.
In addition to the change you've started, I refactored some classes to meet PSR-0 requirements.

A summary of the changes I've made:

  1. Turned config.php into a class with a namespace, Instead of using global variable, Config behave as a variable storage and provides static method to set and get variables. Changed the entire project to work with the new class, Now it's not necessary to required "config.php"
  2. Changed Contrib/*, all of the classes are in a namespace now.
  3. Added support for "list" api method in google prediction api
  4. Fixed some issues

@evert
Copy link
Owner

evert commented Jul 27, 2012

That is a bad-ass diff. Thanks!

evert added a commit that referenced this pull request Jul 27, 2012
@evert evert merged commit ce708e7 into evert:master Jul 27, 2012
EdwinLove referenced this pull request in EdwinLove/google-api-php-client Dec 12, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants