Allow specifying lang order independently of names

[wfdd]

This moves a few things around in scrape_wikidata to make it possible
to use the lang parameter (renamed lang_precedence) when passing a
list of ids and no names hash. Creating the names hash would've
been shadowed by a non-nil lang on line 70.

[wfdd]

I've flipped through all 17 pages of https://github.com/search?l=ruby&q=scrape_wikidata&type=Code&utf8=✓ and lang wasn't in any of the results, which is why I felt safe to rename the parameter.

Tests would probably be nice.

[tmtmtmtm]

thanks @wfdd — at a team meeting yesterday and today, so haven't had a chance to look too deeply at this yet.

The logic is getting quite complex now, so, yes, I think tests are definitely high priority (and adding them would probably force us to refactor in useful ways so we can actually get at the things that are important to test)

[wfdd]

Do you wanna mock the I/O methods or uncouple them entirely and only test the data munging bits? I've not seriously worked in Ruby before, but I could give it a shot.

On 14 Jul 2016, at 10:42, Tony Bowden notifications@github.com wrote:

thanks @wfdd — at a team meeting yesterday and today, so haven't had a chance to look too deeply at this yet.

The logic is getting quite complex now, so, yes, I think tests are definitely high priority (and adding them would probably force us to refactor in useful ways so we can actually get at the things that are important to test)

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

[tmtmtmtm]

If I implemented it myself I'd probably split the parts out to separate method so we could test them independently, but that's not based on actually having looked into how that might work, so if you do have a go, feel free to do whatever is easiest for you.

FWIW, rather than mocking, we tend to just use the vcr gem to record actual results — though here I'd be more concerned with just making sure we're passing the right thing to Wikisnakker/ScraperWiki etc, and trust them to do the right things (or improve the testing of those parts elsewhere).

[wfdd]

Probably not gonna have time to refactor this if you wanna close it or merge it anyway.