Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v5: Add Corporation Wardec notifications #99

Merged
merged 2 commits into from
Mar 28, 2024

Conversation

moppa
Copy link
Contributor

@moppa moppa commented Mar 26, 2024

V5 re-implementation of #91

  • Adds notification for the WarDeclared notification which is sent to Corporations when a war declaration is made.
  • Fixes an issue that the notification fails if the attacker or defender does not exist in UniverseName yet.

If the UniverseName is not yet populated then the category property is null. Which makes the call to zKillBoardToDiscordLink fail with the error

zKillBoardToDiscordLink(): Argument #1 ($type) must be of type string, null given

@moppa moppa force-pushed the feature/v5-corp-wardec branch from d17d2a7 to 4b182ab Compare March 26, 2024 20:43
@Crypta-Eve Crypta-Eve merged commit 7d9b7af into eveseat:5.0.x Mar 28, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants