Updated error reporting

evg4b · Nov 11, 2024 · bd7ae19 · bd7ae19
1 parent 540fec9
commit bd7ae19
Show file tree

Hide file tree

Showing 7 changed files with 22 additions and 9 deletions.
diff --git a/eslint.config.mjs b/eslint.config.mjs
@@ -22,6 +22,7 @@ export default tseslint.config(
   {
     rules: {
       '@typescript-eslint/no-confusing-void-expression': 'off',
+      '@typescript-eslint/use-unknown-in-catch-callback-variable': 'off',
       '@typescript-eslint/restrict-template-expressions': [
         'error',
         {

diff --git a/packages/tokenizer/models.ts b/packages/tokenizer/models.ts
@@ -42,8 +42,9 @@ export type TokenNode = ObjectNode | ArrayNode | StringNode | NumberNode | Boole
 
 export interface ErrorNode {
   type: 'error';
-  scope: 'jq' | 'tokenizer';
+  scope: 'jq' | 'tokenizer' | 'worker';
   error: string;
+  stack?: string;
 }
 
 export type TokenizerResponse = TokenNode | TupleNode | ErrorNode;
diff --git a/src/background/background.ts b/src/background/background.ts
@@ -9,15 +9,29 @@ chrome.runtime.onMessage.addListener(function (message: TokenizeParams | JqParam
   if (is(message, 'tokenize')) {
     tokenize(message.json)
       .then(sendResponse)
-      .catch((err: unknown) => console.error(err));
+      .catch((err: Error) =>
+        sendResponse({
+          type: 'error',
+          scope: 'worker',
+          stack: err.stack,
+          error: err.message,
+        })
+      );
 
     return true;
   }
 
   if (is(message, 'jq')) {
     jq(message.json, message.query)
       .then(sendResponse)
-      .catch((err: unknown) => console.error(err));
+      .catch((err: Error) =>
+        sendResponse({
+          type: 'error',
+          scope: 'worker',
+          stack: err.stack,
+          error: err.message,
+        })
+      );
 
     return true;
   }

diff --git a/src/background/helpres.ts b/src/background/helpres.ts
@@ -1,9 +1,8 @@
 import { JqParams, Message, TokenizeParams } from '@core/background';
 
-
 interface Types {
-  'jq': JqParams,
-  'tokenize': TokenizeParams,
+  jq: JqParams;
+  tokenize: TokenizeParams;
 }
 
 export const is = <T extends Message['action']>(message: object, type: T): message is Types[T] => {

diff --git a/src/core/background/jq.ts b/src/core/background/jq.ts
@@ -5,4 +5,3 @@ import { TokenizerResponse } from '@packages/tokenizer';
 export const jq = async (json: string, query: string): Promise<TokenizerResponse> => {
   return sendMessage<JqParams, TokenizerResponse>({ action: 'jq', json, query });
 };
-
diff --git a/src/core/background/models.ts b/src/core/background/models.ts
@@ -1,4 +1,4 @@
-import { TokenizerResponse } from "@packages/tokenizer";
+import { TokenizerResponse } from '@packages/tokenizer';
 
 export interface TokenizeParams {
   action: 'tokenize';

diff --git a/src/core/background/tokenize.ts b/src/core/background/tokenize.ts
@@ -5,4 +5,3 @@ import { TokenizerResponse } from '@packages/tokenizer';
 export const tokenize = async (json: string): Promise<TokenizerResponse> => {
   return sendMessage<TokenizeParams, TokenizerResponse>({ action: 'tokenize', json });
 };
-
Original file line number	Diff line number	Diff line change
Expand Up		@@ -5,4 +5,3 @@ import { TokenizerResponse } from '@packages/tokenizer';
		export const jq = async (json: string, query: string): Promise<TokenizerResponse> => {
		return sendMessage<JqParams, TokenizerResponse>({ action: 'jq', json, query });
		};
Original file line number	Diff line number	Diff line change
Expand Up		@@ -5,4 +5,3 @@ import { TokenizerResponse } from '@packages/tokenizer';
		export const tokenize = async (json: string): Promise<TokenizerResponse> => {
		return sendMessage<TokenizeParams, TokenizerResponse>({ action: 'tokenize', json });
		};